Change language statistics to save size instead of percentage #11681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
added
type/enhancement
zeripath
approved these changes
May 29, 2020
GiteaBot
added
the
lgtm/need 1
CirnoT
suggested changes
May 29, 2020
CirnoT
reviewed
May 29, 2020
lafriks
force-pushed
the
fix/langstats_storage
branch
from
c9baf71 to
c5007df
Compare
CirnoT
approved these changes
May 29, 2020
GiteaBot
added
lgtm/done
Member
|
How does this fix the case of |
Member
Author
|
@silverwind what do you mean |
Member
|
You linked #11672 but I fail to see how it's related. |
Contributor
|
@silverwind It includes fix from #11672 along with necessary changes, so that there is no need to resolve merge conflicts for either of PRs. |
Member
|
Ah, missed that. Carry on. |
Contributor
|
@lafriks needs an update |
…base Co-Authored-By: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com>
lafriks
force-pushed
the
fix/langstats_storage
branch
from
c5007df to
995d265
Compare
Member
Author
|
@zeripath fixed some edge cases with special languages, should pass tests now |
Member
Author
|
make lg-tm work |
lafriks
added a commit
to lafriks-fork/gitea
that referenced
this pull request
Jun 1, 2020
…ea#11681) * Change language statistics to save size instead of percentage in database Co-Authored-By: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> * Do not exclude if only language * Fix edge cases with special langauges Co-authored-by: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com>
lafriks
added a commit
that referenced
this pull request
Jun 2, 2020
#11690) * Change language statistics to save size instead of percentage (#11681) * Change language statistics to save size instead of percentage in database Co-Authored-By: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> * Do not exclude if only language * Fix edge cases with special langauges Co-authored-by: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> * Fix language stat calculation (#11692) * Fix language stat calculation * Group languages and ignore 0 size files * remove unneeded code Co-authored-by: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
…ea#11681) * Change language statistics to save size instead of percentage in database Co-Authored-By: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> * Do not exclude if only language * Fix edge cases with special langauges Co-authored-by: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11672
Fixes #10567
Co-Authored-By: Cirno the Strongest 1447794+CirnoT@users.noreply.github.com