Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle expected errors in AddGPGkey API #11644

Merged
merged 5 commits into from
May 28, 2020
Merged

Handle expected errors in AddGPGkey API #11644

merged 5 commits into from
May 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 27, 2020

as title

@6543 6543 mentioned this pull request May 27, 2020
Merged
@6543
Copy link
Member Author

6543 commented May 27, 2020

needed for #11641

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 27, 2020
@6543 6543 mentioned this pull request May 27, 2020
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 27, 2020
@zeripath
Copy link
Contributor

I don't think this is breaking. This might sound a bit harsh but we never said that 500 was a valid result - so although people might have been using it - it does not form an advertised API.

TBH If they had been using the 500 they should have reported it as a bug.

@zeripath zeripath added the modifies/api This PR adds API routes or modifies them label May 27, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 27, 2020
@zeripath zeripath changed the title [API] AddGPGkey handle expected errors Handle expected errors in AddGPGkey API May 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2020
@6543
Copy link
Member Author

6543 commented May 28, 2020

ready to merge

@techknowlogick techknowlogick merged commit 560744f into go-gitea:master May 28, 2020
@techknowlogick
Copy link
Member

@6543 please backport :)

@6543 6543 deleted the api_gpg-handle-errors branch May 28, 2020 21:26
6543 added a commit to 6543-forks/gitea that referenced this pull request May 28, 2020
@6543
Handle expected errors in AddGPGkey API (go-gitea#11644)
f2b80d1 
* handle GPG Parse & Email Errors

* correct TEST

* update Swagger

* more Docu
@6543 6543 mentioned this pull request May 28, 2020
Merged
@6543
Copy link
Member Author

6543 commented May 28, 2020

@techknowlogick #11661

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 28, 2020
techknowlogick pushed a commit that referenced this pull request May 28, 2020
@6543
Handle expected errors in AddGPGkey API (#11644) (#11661)
762c046 
* handle GPG Parse & Email Errors

* correct TEST

* update Swagger

* more Docu
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Handle expected errors in AddGPGkey API (go-gitea#11644)
580be49 
* handle GPG Parse & Email Errors

* correct TEST

* update Swagger

* more Docu
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @zeripath @techknowlogick @lafriks @GiteaBot