Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow down Edge version in browser support docs #11640

Merged
merged 3 commits into from
May 31, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 27, 2020

I noticed that Edge 14 has a pretty buggy fetch implementation and because it has already reached end of support I think it's better we don't specifically state support for it, even if it may work to some extend.

I noticed that Edge 14 has a pretty buggy fetch implementation and
because it has already reached end of support I think it's better we
don't specifically state support for it, even if it may work to some
extend.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 27, 2020
@CirnoT
Copy link
Contributor

CirnoT commented May 27, 2020

Might need to differentiate between EdgeHTML-based and Chromium-based. Also the current number (14) refers to EdgeHTML engine, not browser version, unlike others.

@silverwind
Copy link
Member Author

I wouldn't differentiate. The last two EdgeHTML versions should still support everything we need and new Chromium versions will only get better.

Yes I realized the 14 was an error on my side, it should have been 38.

@CirnoT
Copy link
Contributor

CirnoT commented May 27, 2020

In time we might want to deprecate support for EdgeHTML entirely.

I'm also sure that some companies would want to know whether EdgeHTML is supported or not (note that on Pro and Enterprise Chromium Edge is still manual process) so I think it would be worth to note that we support EdgeHTML 38+ and last 2 versions of Chromium Edge.

@silverwind
Copy link
Member Author

silverwind commented May 27, 2020

Splitted it up:

Last two EdgeHTML Edge is 42 and 44
Last two Chromium Edge is 81 and 83

I'm sure older versions do work to some extend but we should only offer support for the mentioned versions.

@CirnoT
Copy link
Contributor

CirnoT commented May 27, 2020

Oh yeah, 38+ was error on my part.

@CirnoT
Copy link
Contributor

CirnoT commented May 27, 2020

Looks weird with

Edge and Edge

@silverwind
Copy link
Member Author

Looks weird

I think it's fine. "Edge (Chromium and EdgeHTML)" would less clear.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2020
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label May 29, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone May 31, 2020
@techknowlogick techknowlogick merged commit cdec70f into go-gitea:master May 31, 2020
@silverwind silverwind deleted the edge-version branch May 31, 2020 08:30
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Narrow down Edge version in browser support docs

I noticed that Edge 14 has a pretty buggy fetch implementation and
because it has already reached end of support I think it's better we
don't specifically state support for it, even if it may work to some
extend.

* mention both edge versions

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants