Fix message wrapping on PR commit list #11616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if we should just have these truncate rather than wrap? |
GiteaBot
added
the
lgtm/need 2
|
They are truncated when multi-line. |
zeripath
approved these changes
May 26, 2020
GiteaBot
added
lgtm/need 1
silverwind
reviewed
May 27, 2020
Co-authored-by: silverwind <me@silverwind.io>
silverwind
approved these changes
May 27, 2020
GiteaBot
added
lgtm/done
lafriks
approved these changes
May 27, 2020
|
please resolve conflicts |
…ommit # Conflicts: # templates/repo/commits_list_small.tmpl
|
make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Fix message wrapping on PR commit list * Update templates/repo/commits_list_small.tmpl Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
The example has exactly 100 characters but it's perfectly possible to remote-branch merges for branches with long names to take more, personally I have noticed it for message with 120 characters.