Fix margin for attached top header on code review #11571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
approved these changes
May 23, 2020
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
May 24, 2020
GiteaBot
added
lgtm/done
|
Thanks @CirnoT In order to reduce the delays for merging I wonder if we could try to bunch some of these styling fixes (for at least the backports.) |
lafriks
approved these changes
May 25, 2020
|
Please send backport |
CirnoT
added a commit
to CirnoT/gitea
that referenced
this pull request
May 25, 2020
Introduced naively by go-gitea#11463 The margin was being applied too widely. (cherry picked from commit e682a92)
techknowlogick
added
the
backport/done
techknowlogick
pushed a commit
that referenced
this pull request
May 26, 2020
* Fix inconsistent font size for markdown preview on new PR view (#11565) We use same method for new issue form and issue view, but was missing from new PR view making it one place where markdown preview is inconsistent in font size. (cherry picked from commit 04afd9d) * Fix margin on PR form (#11566) (cherry picked from commit f2a0be1) * Fix margin for attached top header on code review (#11571) Introduced naively by #11463 The margin was being applied too widely. (cherry picked from commit e682a92) * Fix styling for PR merge section when no checks (#11609) Makes styling consistent between two cases. Also removed unnecessary double border. * Normalize avatar radius
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Introduced naively by go-gitea#11463 The margin was being applied too widely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced naively by #11463
The margin was being applied too widely. Fixes this: