-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add internal-repo octicon for public repos of private org #11529
Conversation
CirnoT
commented
May 21, 2020
•
edited
Loading
edited
# Conflicts: # templates/explore/repo_list.tmpl
…repo_octicon # Conflicts: # templates/user/dashboard/repolist.tmpl
Based on GitHub documentation I believe this is correct usage for this octicon (repository within organization that is visible to all organization members with implicit read access)
(enterprise account I believe would translate to organization for us) As for color; I don't have GitHub Enterprise to compare but based on screenshot available on https://github.blog/2019-11-05-internal-repositories-are-now-generally-available-for-github-enterprise/ the gold color is correct |
Would it make sense to have it as a third repo type (besides public and private)? Seeing the GH screenshot appears they handle it that way. |
GH has no concept of organization visibility, while we do. For GH it is third repo type, for us it is combination of private organization and public repository. We could of course add a visual third type on repo page, but it would be essentially same as public and work only within private repository. |
How does it look along with a repository avatar? My company uses avatars for each repository for quick identifying (e.g. firmware, tools, front-end, etc.) |
Same as any other icon, like private/public. If i recall correctly from looking at the code, the avatar always takes priority. |
…1529) * Show multiple octicons on repo list * fix mixed spaces/tabs * Internal repo octicon * show internal icon in dashboard repolist * swagger * fix icon for normal repo on repo page * don't expose owner visibility directly; provide internal in repo api * fix icons for forks and mirrors Co-authored-by: Lauris BH <lauris@nix.lv>