Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal-repo octicon for public repos of private org #11529

Merged
merged 14 commits into from
Jun 5, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 21, 2020

chrome_2020-05-21_03-40-47
chrome_2020-05-21_03-40-54
chrome_2020-05-21_04-02-33

@CirnoT CirnoT changed the title Internal repo octicon Add internal-repo octicon for public repos of private org May 21, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented May 21, 2020

Based on GitHub documentation I believe this is correct usage for this octicon (repository within organization that is visible to all organization members with implicit read access)

https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-repository-visibility#about-internal-repositories

You can use internal repositories to practice "innersource" within your enterprise account. Members of your enterprise account can collaborate using open source methodologies without sharing proprietary information publicly

All enterprise members have read permissions to the internal repository, but internal repositories are not visible to people outside of the enterprise account, including outside collaborators on organization repositories

(enterprise account I believe would translate to organization for us)

As for color; I don't have GitHub Enterprise to compare but based on screenshot available on https://github.blog/2019-11-05-internal-repositories-are-now-generally-available-for-github-enterprise/ the gold color is correct

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 21, 2020
@CirnoT CirnoT marked this pull request as ready for review May 21, 2020 21:55
@silverwind
Copy link
Member

silverwind commented May 22, 2020

Would it make sense to have it as a third repo type (besides public and private)? Seeing the GH screenshot appears they handle it that way.

@CirnoT
Copy link
Contributor Author

CirnoT commented May 22, 2020

GH has no concept of organization visibility, while we do. For GH it is third repo type, for us it is combination of private organization and public repository.

We could of course add a visual third type on repo page, but it would be essentially same as public and work only within private repository.

@guillep2k
Copy link
Member

How does it look along with a repository avatar? My company uses avatars for each repository for quick identifying (e.g. firmware, tools, front-end, etc.)

@CirnoT
Copy link
Contributor Author

CirnoT commented Jun 1, 2020

Same as any other icon, like private/public. If i recall correctly from looking at the code, the avatar always takes priority.

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Jun 1, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 1, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 2, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 4, 2020
@lafriks lafriks merged commit 5acba46 into go-gitea:master Jun 5, 2020
@CirnoT CirnoT deleted the internal-repo_octicon branch June 5, 2020 12:26
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…1529)

* Show multiple octicons on repo list

* fix mixed spaces/tabs

* Internal repo octicon

* show internal icon in dashboard repolist

* swagger

* fix icon for normal repo on repo page

* don't expose owner visibility directly; provide internal in repo api

* fix icons for forks and mirrors

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants