Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manpage Make Target #11476

Closed
wants to merge 6 commits into from
Closed

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented May 18, 2020

This PR adds make target for manpage, and also stub (empty) markdown source to generate them.

This issue is part of resolving #11399.

The actual manpage content will be provided in next PR when this PR get merged.

@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label May 18, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 18, 2020
Makefile Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 23, 2020
@silverwind
Copy link
Member

I think you need to run make vendor and add the new files in the vendor directory.

@bagasme
Copy link
Contributor Author

bagasme commented May 23, 2020

@silverwind I don't think vendoring will be appropriate for this. It is similar to misspell target: if go-md2man isn't found, go get it. go-md2man is executable, not library one.

@silverwind
Copy link
Member

Ok, I was just wondering about the entry in go.sum but I guess as long as it's not in go.mod, go vendor will not pick it up as a vendoring candidate.

@silverwind silverwind mentioned this pull request May 24, 2020
.gitignore Show resolved Hide resolved
@stale
Copy link

stale bot commented Aug 19, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 19, 2020
@stale stale bot removed the issue/stale label Aug 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 19, 2020
@silverwind
Copy link
Member

Would prefer this to land in the same PR with the actual content for #11399.

Makefile Outdated Show resolved Hide resolved
Turned off Go Module

Co-authored-by: silverwind <me@silverwind.io>
@techknowlogick techknowlogick modified the milestones: 1.13.0, 1.14.0 Sep 9, 2020
@stale
Copy link

stale bot commented Nov 9, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added issue/stale and removed issue/stale labels Nov 9, 2020
@6543 6543 mentioned this pull request Dec 8, 2020
@6543 6543 removed this from the 1.14.0 milestone Feb 19, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
@bagasme bagasme deleted the manpage-make-target branch May 5, 2022 04:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants