Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change tab width for .go files to 4 #11455

Merged
merged 3 commits into from
May 17, 2020
Merged

Change tab width for .go files to 4 #11455

merged 3 commits into from
May 17, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 17, 2020 •
edited
Loading

I thing 8-wide tabs are kind of archaic and inconsistent with template files which already use 4-wide.

Also did some misc cleanups in the .editorconfig files.

@silverwind
Change tab width for .go files to 4
8dc4532 
I thing 8-wide tabs are kind of archaic and inconsisten with template
files which already use 4-wide.

Also did some misc cleanups in the .editorconfig files.
6543
6543 reviewed May 17, 2020
View reviewed changes
.editorconfig Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 17, 2020
@silverwind
Copy link
Member Author

silverwind commented May 17, 2020 •
edited
Loading

gofmt hardcodes tab width to 8, so I'm not sure it's wise to change it because if gofmt outputs spaces those would be misaligned. Does anyone know if gofmt can output spaces for alignment in some cases or is it all tabs?

@silverwind
Copy link
Member Author

silverwind commented May 17, 2020 •
edited
Loading

Based on golang/go@25b5181, I think it's fine we change this. It says tab width has no effect on alignment:

Since "columns of alignment" are terminated whenever indentation changes from one line to the next, alignment with spaces will work independent of the actually chosen tab width ...

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2020
@lafriks lafriks merged commit 97cabf3 into go-gitea:master May 17, 2020
@silverwind silverwind deleted the go-tab-4 branch May 17, 2020 20:42
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@silverwind @lafriks
Change tab width for .go files to 4 (go-gitea#11455)
ac1e85d 
* Change tab width for .go files to 4

I thing 8-wide tabs are kind of archaic and inconsisten with template
files which already use 4-wide.

Also did some misc cleanups in the .editorconfig files.

* add css

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/miscellaneous
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lafriks @6543 @GiteaBot