Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api.Context.NotFound(...) should tolerate nil #11288

Merged
merged 3 commits into from
May 5, 2020
Merged

api.Context.NotFound(...) should tolerate nil #11288

merged 3 commits into from
May 5, 2020

Commits on May 4, 2020

  1. api.Context.NotFound(...) should tolerate nil 

    There is an unfortunate signature change with the api.Context
NotFound function; whereas the normal modules/context/Context
NotFound function requires an error or nil, the api.Context
variant will panic with an NPE if a nil is provided.

This PR will allow api.Context.NotFound to tolerate a being
passed a nil.

Signed-off-by: Andrew Thornton <art27@cantab.net>
    @zeripath
    zeripath committed May 4, 2020
    Configuration menu
    Copy the full SHA
    fb46e73 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-11286-api.Context.NotFound-should-tole… 

    …rate-nils
    @lafriks
    lafriks authored May 4, 2020
    Configuration menu
    Copy the full SHA
    d7211f1 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Merge branch 'master' into fix-11286-api.Context.NotFound-should-tole… 

    …rate-nils
    @lafriks
    lafriks authored May 5, 2020
    Configuration menu
    Copy the full SHA
    8f6740a View commit details
    Browse the repository at this point in the history