Doctor check & fix db consistency #11111

6543 · 2020-04-17T15:30:21Z

as title

needed to fix issue as described in #10280

rename check-db to check-db-version
add check-db-consistency:
- find issues without existing repository
- find pulls without existing issues
- find tracked times without existing issues/pulls
- find labels without repository or org reference

6543 · 2020-04-17T15:38:08Z

backport would be usefull (look at #10280)

guillep2k · 2020-04-18T04:18:41Z

@lunny it shouldn't be breaking if it's released on 1.12.0 and backported to 1.11.5, since the doctor hasn't been released yet. 👨‍⚕️

cmd/doctor.go

codecov-io · 2020-04-19T00:02:01Z

Codecov Report

Merging #11111 into master will decrease coverage by 0.08%.
The diff coverage is 8.54%.

@@            Coverage Diff             @@
##           master   #11111      +/-   ##
==========================================
- Coverage   43.97%   43.88%   -0.09%     
==========================================
  Files         614      614              
  Lines       87457    87607     +150     
==========================================
- Hits        38459    38449      -10     
- Misses      44263    44421     +158     
- Partials     4735     4737       +2

Impacted Files	Coverage Δ
cmd/doctor.go	`0.00% <0.00%> (ø)`
models/consistency.go	`56.93% <0.00%> (-39.71%)`	⬇️
models/issue.go	`51.57% <30.76%> (-0.85%)`	⬇️
models/repo.go	`52.90% <50.00%> (+0.69%)`	⬆️
models/repo_mirror.go	`2.12% <0.00%> (-10.64%)`	⬇️
modules/git/repo.go	`47.28% <0.00%> (-3.77%)`	⬇️
services/pull/temp_repo.go	`34.18% <0.00%> (-3.42%)`	⬇️
services/mirror/mirror.go	`18.38% <0.00%> (-0.65%)`	⬇️
services/pull/pull.go	`33.39% <0.00%> (-0.58%)`	⬇️
modules/log/event.go	`65.64% <0.00%> (+1.02%)`	⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2b86ea...a0f626e. Read the comment docs.

6543 · 2020-04-19T00:36:25Z

@guillep2k created new function explicit for Issue Deletion
(move issue delete code out of RepoDeletion)

models/issue.go

cmd/doctor.go

models/issue.go

6543 · 2020-04-19T16:48:40Z

@guillep2k @lunny I put the part (reason for this feature) into #11138 as Backport to let users fix there instances - can we add #11138 to the 1.11.5 milestone ?

cmd/doctor.go

lunny · 2020-05-01T15:46:43Z

@lunny it shouldn't be breaking if it's released on 1.12.0 and backported to 1.11.5, since the doctor hasn't been released yet. 👨‍⚕️

So this PR is break in v1.12 but not in v1.11 ?

6543 · 2020-05-01T16:01:45Z

@lunny
do not know, the doctor function ins in master and release-1.11 branch ...

I'll work on this the next days to finish it ... this should realy go into the v1.12 release ...

This reverts commit a9dcb3e.

6543 · 2020-05-28T18:50:11Z

done

cmd/doctor.go

6543 · 2020-05-28T22:49:25Z

its finaly ready to merge 🚀

6543 · 2020-05-28T23:04:50Z

I think we should backport this to v1.12

needed to fix issue as described in go-gitea#10280 * rename check-db to check-db-version * add check-db-consistency: * find issues without existing repository * find pulls without existing issues * find tracked times without existing issues/pulls * find labels without repository or org reference Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

6543 · 2020-05-29T13:35:11Z

Backports: #11676
and partial #11138

…s of go-gitea#11111

Backports the tracked-time fix from #11111 (part of #11111) Fixes tracked time errors following repo deletion (#10280) and adds the fix to the default doctor tasks

needed to fix issue as described in #10280 * rename check-db to check-db-version * add check-db-consistency: * find issues without existing repository * find pulls without existing issues * find tracked times without existing issues/pulls * find labels without repository or org reference Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Co-authored-by: Guillermo Prandi <guillep2k@users.noreply.github.com>

needed to fix issue as described in go-gitea#10280 * rename check-db to check-db-version * add check-db-consistency: * find issues without existing repository * find pulls without existing issues * find tracked times without existing issues/pulls * find labels without repository or org reference Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

6543 added 3 commits April 17, 2020 16:29

rename check-db to check-db-version to have multible db checks

4120aa1

add runDoctorCheckDBConsistency

2627b81

add find pulls without existing issues

fe48054

6543 mentioned this pull request Apr 17, 2020

Times API breaks after deleting repo containing issues with tracked times #10280

Closed

7 tasks

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2020

lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 17, 2020

6543 added 2 commits April 17, 2020 18:37

Merge branch 'master' into doctor-check-fix-db-consistency_10280

21330fd

Merge branch 'master' into doctor-check-fix-db-consistency_10280

7e261d0

lunny added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Apr 18, 2020

guillep2k reviewed Apr 18, 2020

View reviewed changes

cmd/doctor.go Outdated Show resolved Hide resolved

Merge branch 'master' into doctor-check-fix-db-consistency_10280

ea605b7

6543 added 3 commits April 19, 2020 02:32

move Issue Deletion to issue.go

5cfa0d4

use DeleteIssuesByIDs

b8b5de3

Merge branch 'master' into doctor-check-fix-db-consistency_10280

ec02b3a

6543 commented Apr 19, 2020

View reviewed changes

models/issue.go Outdated Show resolved Hide resolved

6543 added 2 commits April 19, 2020 02:56

use err

17589b9

just another one

d6f1f0e

lunny requested changes Apr 19, 2020

View reviewed changes

cmd/doctor.go Outdated Show resolved Hide resolved

models/issue.go Outdated Show resolved Hide resolved

models/issue.go Outdated Show resolved Hide resolved

6543 mentioned this pull request Apr 19, 2020

Add tracked time fix to doctor (part of #11111) #11138

Merged

Merge branch 'master' into doctor-check-fix-db-consistency_10280

bd8a751

lunny reviewed Apr 22, 2020

View reviewed changes

cmd/doctor.go Outdated Show resolved Hide resolved

6543 changed the title ~~[Feature] Doctor check&fix db consistency~~ [WIP] [Feature] Doctor check&fix db consistency Apr 22, 2020

6543 mentioned this pull request Apr 28, 2020

[bug] [api] issueGetLabels dont return correct responce #11238

Closed

6543 added 3 commits May 28, 2020 20:46

Revert "only sync if needed"

a76c2f2

This reverts commit a9dcb3e.

add documentation

704e359

Merge branch 'master' into doctor-check-fix-db-consistency_10280

f9bd1a4

its Nr 11111

0ae896d

guillep2k reviewed May 28, 2020

View reviewed changes

cmd/doctor.go Outdated Show resolved Hide resolved

its an error now

d2e438d

guillep2k approved these changes May 28, 2020

View reviewed changes

Merge branch 'master' into doctor-check-fix-db-consistency_10280

9d8f61e

guillep2k added this to the 1.13.0 milestone May 29, 2020

Merge branch 'master' into doctor-check-fix-db-consistency_10280

7dca8b4

zeripath added the backport/v1.12 label May 29, 2020

zeripath approved these changes May 29, 2020

View reviewed changes

zeripath changed the title ~~[Feature] Doctor check&fix db consistency~~ Doctor check&fix db consistency May 29, 2020

zeripath changed the title ~~Doctor check&fix db consistency~~ Doctor check & fix db consistency May 29, 2020

zeripath merged commit 726e1e5 into go-gitea:master May 29, 2020

6543 deleted the doctor-check-fix-db-consistency_10280 branch May 29, 2020 13:33

6543 mentioned this pull request May 29, 2020

Doctor check & fix db consistency (#11111) #11676

Merged

zeripath added the backport/done All backports for this PR have been created label May 29, 2020

6543 added a commit to adelowo/gitea that referenced this pull request May 29, 2020

delete Projects and related correctly on RepoDeletion -> adapt change…

6f49097

…s of go-gitea#11111

guillep2k added a commit to guillep2k/gitea that referenced this pull request May 30, 2020

Add missing check for go-gitea#11111 backport

74dbf1a

guillep2k added a commit that referenced this pull request May 30, 2020

Add missing check for #11111 backport (#11693)

161e550

Co-authored-by: Guillermo Prandi <guillep2k@users.noreply.github.com>

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Uh oh!

Doctor check & fix db consistency #11111

Doctor check & fix db consistency #11111

Uh oh!

Conversation

6543 commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

6543 commented Apr 17, 2020

Uh oh!

guillep2k commented Apr 18, 2020

Uh oh!

Uh oh!

codecov-io commented Apr 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

6543 commented Apr 19, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

6543 commented Apr 19, 2020

Uh oh!

Uh oh!

lunny commented May 1, 2020

Uh oh!

6543 commented May 1, 2020

Uh oh!

6543 commented May 28, 2020

Uh oh!

Uh oh!

6543 commented May 28, 2020

Uh oh!

6543 commented May 28, 2020

Uh oh!

6543 commented May 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

6543 commented Apr 17, 2020 •

edited

Loading

codecov-io commented Apr 19, 2020 •

edited

Loading