Skip to content

Avoid '0 new commits' messages to be send to webhook #11082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2020
Merged

Avoid '0 new commits' messages to be send to webhook #11082

merged 3 commits into from
Apr 18, 2020

Conversation

@cornelk
Copy link
Contributor

@cornelk cornelk commented Apr 15, 2020

Fixes #10498

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Apr 15, 2020
@lafriks lafriks added this to the 1.12.0 milestone Apr 15, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 16, 2020
@6543
Copy link
Member

6543 commented Apr 16, 2020

looks good - since only on push you will have new commits

guillep2k
guillep2k approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds about right.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 17, 2020
@zeripath
Copy link
Contributor

zeripath commented Apr 18, 2020

make lg-tm work

@zeripath zeripath merged commit 6034f8b into go-gitea:master Apr 18, 2020
@CirnoT
Copy link
Contributor

CirnoT commented May 12, 2020 •
edited
Loading

Should be marked as breaking possibly, Drone did depend on this to fetch additional data for tags https://github.com/drone/drone/blob/c81263687c4af650e4a0d05444f2fc5a1541e5be/service/hook/parser/parse.go#L189

An issue was also raised that it might be an undesired regression - harness/harness#2966 (comment)

@CirnoT CirnoT mentioned this pull request May 12, 2020
Closed
zeripath added a commit that referenced this pull request May 13, 2020
@zeripath
Revert "Avoid 0 new commits messages to be send (#11082)"
ba42196 
This reverts commit 6034f8b.
@zeripath zeripath mentioned this pull request May 13, 2020
Merged
lafriks pushed a commit that referenced this pull request May 13, 2020
@zeripath
Revert "Avoid 0 new commits messages to be send (#11082)" (#11397)
8d212f7 
This reverts commit 6034f8b.
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 17, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@cornelk
Avoid 0 new commits messages to be send (go-gitea#11082)
0c1e412 
Fixes go-gitea#10498
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@zeripath
Revert "Avoid 0 new commits messages to be send (go-gitea#11082)" (go…
5e4510e 
…-gitea#11397)

This reverts commit 6034f8b.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

Slack webhook showing message 0 new commits pushed

8 participants

@cornelk @6543 @zeripath @CirnoT @guillep2k @lafriks @GiteaBot @techknowlogick