Skip to content

Return issue subscription status from API subscribe #10966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 30, 2020
Merged

Return issue subscription status from API subscribe #10966

merged 7 commits into from
Apr 30, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Apr 4, 2020 •
edited
Loading

close #10958

ToDo

  • indicate
  • fix tests
  • extend test

@6543 6543 changed the title [API] issue subscription indicate 10958 [API] issue subscription indicate Apr 5, 2020
@6543 6543 mentioned this pull request Apr 5, 2020
Merged
2 tasks
@6543
Copy link
Member Author

6543 commented Apr 5, 2020

depend on #10967 to add tests

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 5, 2020
@6543 6543 changed the title [API] issue subscription indicate [WIP] [API] issue subscription indicate Apr 5, 2020
@codecov-io
Copy link

codecov-io commented Apr 5, 2020 •
edited
Loading

Codecov Report

Merging #10966 into master will increase coverage by 0.02%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10966      +/-   ##
==========================================
+ Coverage   43.17%   43.20%   +0.02%     
==========================================
  Files         604      604              
  Lines       86056    86069      +13     
==========================================
+ Hits        37152    37183      +31     
+ Misses      44310    44292      -18     
  Partials     4594     4594
Impacted Files Coverage Δ
routers/api/v1/repo/issue_subscription.go 57.14% <73.33%> (+0.72%) ⬆️
modules/indexer/stats/queue.go 62.50% <0.00%> (-18.75%) ⬇️
modules/indexer/stats/db.go 40.62% <0.00%> (-9.38%) ⬇️
modules/git/utils.go 65.67% <0.00%> (-4.48%) ⬇️
modules/git/repo.go 47.28% <0.00%> (-3.35%) ⬇️
services/pull/pull.go 34.16% <0.00%> (+0.19%) ⬆️
models/issue.go 51.86% <0.00%> (+0.46%) ⬆️
modules/notification/webhook/webhook.go 40.20% <0.00%> (+0.58%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.76% <0.00%> (+1.92%) ⬆️
models/unit.go 44.44% <0.00%> (+2.46%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e799c2...80dd6ba. Read the comment docs.

@guillep2k guillep2k added the modifies/api This PR adds API routes or modifies them label Apr 5, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Apr 11, 2020
@techknowlogick techknowlogick added the pr/wip This PR is not ready for review label Apr 11, 2020
@6543
Copy link
Member Author

6543 commented Apr 17, 2020

still blocked by #10967

@6543 6543 changed the title [WIP] [API] issue subscription indicate [WIP] [API] issue subscription indicate by http status Apr 18, 2020
@6543
Copy link
Member Author

6543 commented Apr 21, 2020

Test Only Fail because of GitHub outage

@6543 6543 changed the title [WIP] [API] issue subscription indicate by http status [API] issue subscription indicate by http status Apr 21, 2020
@techknowlogick techknowlogick removed the pr/wip This PR is not ready for review label Apr 21, 2020
zeripath
zeripath reviewed Apr 21, 2020
View reviewed changes
zeripath
zeripath reviewed Apr 21, 2020
View reviewed changes
zeripath
zeripath reviewed Apr 21, 2020
View reviewed changes
zeripath
zeripath reviewed Apr 21, 2020
View reviewed changes
zeripath
zeripath approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 21, 2020
@6543
Copy link
Member Author

6543 commented Apr 22, 2020 •
edited
Loading

ready to merge need 2nd lgmt

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 24, 2020
@guillep2k
Copy link
Member

guillep2k commented Apr 25, 2020

@6543 make sure you enable "allow edit by maintainers" so we can update the branch and merge.

image

@6543
Copy link
Member Author

6543 commented Apr 25, 2020

@guillep2k it normaly is ... but I normaly have added you to the fork as colaborator too...

@guillep2k
Copy link
Member

guillep2k commented Apr 26, 2020

@6543 is this currently checked? (in the sidebar at the right) You can change it anytime.

image

@6543
Copy link
Member Author

6543 commented Apr 26, 2020

@guillep2k IF I COULD I WOULD:
Screenshot_20200426-135143_1

@6543
Copy link
Member Author

6543 commented Apr 27, 2020

ready to merger 🚀

@6543 6543 force-pushed the api-IssueSubscription-indicate_10958 branch from a897151 to 66e0e11 Compare April 28, 2020 15:37
@6543
Copy link
Member Author

6543 commented Apr 30, 2020

ping lgtm

@zeripath zeripath changed the title [API] issue subscription indicate by http status Add issue subscription endpoints to API Apr 30, 2020
@zeripath zeripath changed the title Add issue subscription endpoints to API Return issue subscription status from API subscribe Apr 30, 2020
@zeripath zeripath merged commit e9e8638 into go-gitea:master Apr 30, 2020
@6543 6543 deleted the api-IssueSubscription-indicate_10958 branch April 30, 2020 23:21
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@6543
Return issue subscription status from API subscribe (go-gitea#10966)
dc2c216 
* [API] issue subscription indicate by http status

* CI.restart()
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

[Feature] [API] IssueSubscription inidicate if already subscribed

6 participants

@6543 @codecov-io @guillep2k @zeripath @techknowlogick @GiteaBot