Protect against NPEs in notifications list #10879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately there appears to be potential race with notifications being set before the associated issue has been committed. This PR adds protection in to the notifications list to log any failures and remove these notifications from the display. References go-gitea#10815 - and prevents the panic but does not completely fix this. Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
approved these changes
Mar 29, 2020
GiteaBot
added
the
lgtm/need 1
mrsdizzie
approved these changes
Mar 29, 2020
GiteaBot
added
lgtm/done
|
make lg-tm work |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Mar 29, 2020
Unfortunately there appears to be potential race with notifications being set before the associated issue has been committed. This PR adds protection in to the notifications list to log any failures and remove these notifications from the display. References go-gitea#10815 - and prevents the panic but does not completely fix this. Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
reviewed
Mar 30, 2020
| if failures == nil || len(failures) == 0 { | ||
| return nl | ||
| } | ||
| remaining := make([]*Notification, 0, len(nl)) |
There was a problem hiding this comment.
It's better to use len(nl) - len(failures).
lunny
pushed a commit
that referenced
this pull request
Mar 30, 2020
* Protect against NPEs in notifications list (#10879) Unfortunately there appears to be potential race with notifications being set before the associated issue has been committed. This PR adds protection in to the notifications list to log any failures and remove these notifications from the display. References #10815 - and prevents the panic but does not completely fix this. Signed-off-by: Andrew Thornton <art27@cantab.net> * add log import * Update models/notification.go Co-Authored-By: Lauris BH <lauris@nix.lv> Co-authored-by: Lauris BH <lauris@nix.lv>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there appears to be potential race with notifications being set before the associated issue has been committed.
This PR adds protection in to the notifications list to log any failures and remove these notifications from the display - with an untranslated flash error.
References #10815 - and prevents the panic but does not completely fix this.
Signed-off-by: Andrew Thornton art27@cantab.net