-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Set MySQL rowtype to dynamic for new tables #10833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10833 +/- ##
==========================================
- Coverage 43.56% 43.54% -0.02%
==========================================
Files 589 589
Lines 82691 82694 +3
==========================================
- Hits 36023 36008 -15
- Misses 42192 42208 +16
- Partials 4476 4478 +2
Continue to review full report at Codecov.
|
@lafriks would it be worth just writing a migration so we never have to hear about this or get blamed for this again? |
There's a chance this setting is also required?:
See SO. It may depend on the engine version. |
@zeripath We don't need a migration. Once user encountered this problem, it will install gitea failed. |
@guillep2k this needs to be implemented first as param in xorm like it is with rowtype |
Fixes #9347 for new installations and new tables