Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete dependencies when deleting a repository #10608

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Delete dependencies when deleting a repository #10608

merged 3 commits into from
Mar 5, 2020

Conversation

guillep2k
Copy link
Member

Take care of issue_dependency records when deleting a repository.

Should fix #10384

@guillep2k guillep2k added this to the 1.12.0 milestone Mar 4, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 5, 2020
@zeripath
Copy link
Contributor

zeripath commented Mar 5, 2020

Hmm this needs a migration to fix the missed dependencies

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6420f17). Click here to learn what that means.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10608   +/-   ##
=========================================
  Coverage          ?   43.68%           
=========================================
  Files             ?      586           
  Lines             ?    82167           
  Branches          ?        0           
=========================================
  Hits              ?    35895           
  Misses            ?    41821           
  Partials          ?     4451
Impacted Files Coverage Δ
models/repo.go 51.38% <25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6420f17...566bb99. Read the comment docs.

@lafriks lafriks merged commit 6a57364 into go-gitea:master Mar 5, 2020
guillep2k pushed a commit to guillep2k/gitea that referenced this pull request Mar 5, 2020
@lafriks @zeripath @guillep2k
Delete dependencies when deleting a repository (go-gitea#10608)
409c8a1 
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lauris BH <lauris@nix.lv>
This was referenced Mar 5, 2020
Merged
Merged
@guillep2k guillep2k added the backport/done All backports for this PR have been created label Mar 5, 2020
zeripath added a commit that referenced this pull request Mar 5, 2020
@zeripath @lafriks
Delete dependencies when deleting a repository (#10608) (#10616)
c19ac41 
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lauris BH <lauris@nix.lv>

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>
@guillep2k
Copy link
Member Author

Hmm this needs a migration to fix the missed dependencies

@zeripath See #10625

@guillep2k guillep2k deleted the fix-10384 branch March 6, 2020 04:30
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Internal server error trying to access an existing issue
5 participants
@guillep2k @zeripath @codecov-io @lafriks @GiteaBot