Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential bugs (#10513) #10518

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Fix potential bugs (#10513) #10518

merged 2 commits into from
Feb 28, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 28, 2020 •
edited
Loading

  • use e if it is an option
  • potential nil so check err first
  • check err first
  • m == nil already checked

Backports #10513

@6543
Fix potential bugs (go-gitea#10513)
73c7ca8 
* use e if it is an option
* potential nil so check err first
* check err first
* m == nil already checked
@6543 6543 mentioned this pull request Feb 28, 2020
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2020
@guillep2k
Copy link
Member

Ping LG-TM

@guillep2k guillep2k merged commit 11300ee into go-gitea:release/v1.11 Feb 28, 2020
@lunny lunny added this to the 1.11.2 milestone Feb 28, 2020
@lunny lunny added the type/bug label Feb 28, 2020
@6543 6543 deleted the backports_10513 branch September 21, 2020 15:49
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @guillep2k @lunny @jolheiser @GiteaBot