Skip to content

Allow admin to check org membership by API for other users #10201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2020
Merged

Allow admin to check org membership by API for other users #10201

merged 4 commits into from
Feb 9, 2020

Conversation

@6543
Copy link
Member

@6543 6543 commented Feb 9, 2020 •
edited
Loading

close #10194

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 9, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 9, 2020
@codecov-io
Copy link

codecov-io commented Feb 9, 2020 •
edited
Loading

Codecov Report

Merging #10201 into master will decrease coverage by 0.01%.
The diff coverage is 4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10201      +/-   ##
==========================================
- Coverage   43.64%   43.63%   -0.02%     
==========================================
  Files         576      576              
  Lines       79681    79682       +1     
==========================================
- Hits        34779    34771       -8     
- Misses      40612    40622      +10     
+ Partials     4290     4289       -1
Impacted Files Coverage Δ
routers/user/profile.go 50.69% <0%> (-0.97%) ⬇️
routers/routes/routes.go 86.47% <100%> (-0.05%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
modules/queue/workerpool.go 45.55% <0%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8128c89...1449820. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 9, 2020
@lafriks lafriks merged commit 585316f into go-gitea:master Feb 9, 2020
@6543 6543 deleted the fix-10194 branch February 9, 2020 22:47
@zeripath zeripath added the modifies/api This PR adds API routes or modifies them label May 17, 2020
@zeripath zeripath changed the title [API] let admin check org membership on other users Allow admin to check org membership by API for other users May 17, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

[API] CheckOrgMembership hide hidden users eafen if you are admin

5 participants

@6543 @codecov-io @lafriks @zeripath @GiteaBot