Fixes 1019, install page SMTP user is required to to be an email address. #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be an email address. Signed-off-by: P.B. <puffybsd@yahoo.com>
|
LGTM |
tboerger
added
the
lgtm/need 1
lunny
reviewed
Feb 23, 2017
| @@ -124,7 +124,7 @@ func InstallPost(ctx *context.Context, form auth.InstallForm) { | |||
| ctx.Data["CurDbOption"] = form.DbType | |||
|
|
|||
| if ctx.HasError() { | |||
| if ctx.HasValue("Err_SMTPEmail") { | |||
| if ctx.HasValue("Err_SMTPUser") { | |||
There was a problem hiding this comment.
It's a like-for-like change. The previous string, Err_SMTPEmail is not set in ctx.Data. Think this could be a previous bug?
appleboy
approved these changes
Feb 23, 2017
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1019, install page SMTP user is required to to be an email address.
Updates the install page to have an english label of "Sender User" instead of "Sender Email",
removes email validation on the Sender User field, updates the install form, model and route.
Signed-off-by: P.B. puffybsd@yahoo.com