Skip to content

Reorganize frontend files and tooling #10168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2020
Merged

Reorganize frontend files and tooling #10168

merged 4 commits into from
Feb 7, 2020

Conversation

silverwind
Copy link
Member

  • move "vendor" files to js/vendor and less/vendor
  • move swagger to js/standalone (meant for standalone pages)
  • move gitgraph to features and streamline its loading
  • add linting configs to webpack dependencies in make
  • set ignored files for eslint/stylelint directly in their configs

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 6, 2020
@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 6, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 6, 2020
@codecov-io
Copy link

codecov-io commented Feb 6, 2020 •
edited
Loading

Codecov Report

Merging #10168 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10168      +/-   ##
==========================================
- Coverage   43.42%   43.41%   -0.02%     
==========================================
  Files         576      576              
  Lines       79642    79642              
==========================================
- Hits        34585    34577       -8     
- Misses      40780    40788       +8     
  Partials     4277     4277
Impacted Files Coverage Δ
modules/queue/workerpool.go 46.61% <0%> (-2.14%) ⬇️
modules/log/event.go 64.61% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde1a4f...82cdc43. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 7, 2020
@silverwind
Copy link
Member Author

silverwind commented Feb 7, 2020 •
edited
Loading

CI needs a restart (sqlite deadlocked). restarted via force-push.

@silverwind
Reorganize frontend files and tooling
b33b5f1 
- move "vendor" files to js/vendor and less/vendor
- move swagger to js/standalone (meant for standalone pages)
- move gitgraph to features and streamline its loading
- add linting configs to webpack dependencies in make
- set ignored files for eslint/stylelint directly in their configs
@sapk sapk merged commit fdf6d25 into go-gitea:master Feb 7, 2020
@jaqra jaqra mentioned this pull request Feb 10, 2020
Merged
13 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@silverwind @codecov-io @lunny @lafriks @sapk @GiteaBot @zeripath