Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook bug: compare_url is incorrect for a new branch #9243

Open
2 of 7 tasks
bill828 opened this issue Dec 3, 2019 · 3 comments · May be fixed by #25699
Open
2 of 7 tasks

Webhook bug: compare_url is incorrect for a new branch #9243

bill828 opened this issue Dec 3, 2019 · 3 comments · May be fixed by #25699
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP type/bug

Comments

@bill828
Copy link

bill828 commented Dec 3, 2019

  • Gitea version (or commit ref): 1.9.3
  • Git version: 2.16.2
  • Operating system: CentOS 7.5
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

When I push new branch to the gitea server with more than one commits, a push event will be sent to the configured webhook.
However, the fields "before" and "compare_url" are incorrect.
Please see the attachment picture for the screenshot.

Reproduce steps:

  1. Create a new branch with command line "git checkout -b testbranch"
  2. Make some changes and commit.
  3. Push to remote with command line "git push --set-upstream origin testbranch".

Screenshots

Screenshot

@lunny lunny added the type/bug label Dec 3, 2019
@lunny
Copy link
Member

lunny commented Dec 3, 2019

Which version did you use?

@bill828
Copy link
Author

bill828 commented Dec 4, 2019

I was using Gitea 1.9.3.

@stale
Copy link

stale bot commented Feb 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 4, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 4, 2020
@stale stale bot removed the issue/stale label Feb 4, 2020
@lunny lunny linked a pull request Jul 5, 2023 that will close this issue
@lunny lunny added the issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants