Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting review on pull request gives Error 500 #9207

Closed
1 of 7 tasks
davidsvantesson opened this issue Nov 29, 2019 · 1 comment · Fixed by #9229
Closed
1 of 7 tasks

Submitting review on pull request gives Error 500 #9207

davidsvantesson opened this issue Nov 29, 2019 · 1 comment · Fixed by #9229
Labels
type/enhancement An improvement of existing functionality

Comments

@davidsvantesson
Copy link
Contributor

  • Gitea version (or commit ref): 1.10.0
  • Git version: 2.17.1
  • Operating system: Ubuntu
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:
2019/11/29 08:56:59 .../xorm/session_raw.go:194:exec() [I] [SQL] UPDATE `review` SET `type` = ?, `reviewer_id` = ?, `issue_id` = ?, `content` = ?, `updated_unix` = ? WHERE `id`=? []interface {}{3, 60, 84, "<text of ~350 characters>", 1575017819, 82} - took: 1.825014ms
2019/11/29 08:56:59 .../repo/pull_review.go:173:SubmitReview() [E] UpdateReview: Error 1406: Data too long for column 'content' at row 1
2019/11/29 08:56:59 ...s/context/context.go:138:HTML() [D] Template: status/500  

Description

When submitting a review on a pull request I get an Error 500 page. It seem the text you enter when approving or rejecting a PR is only intended to be rather short, and therefore the database column review.content is limited to 255 characters. However the user interface doesn't restrict the input to this limit.

@lunny lunny added the type/enhancement An improvement of existing functionality label Nov 29, 2019
@lunny
Copy link
Member

lunny commented Nov 29, 2019

Change it's tag to TEXT and add a migration will fix that.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants