Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitea returns import path for organization #8095

Closed
2 of 7 tasks
rutgerbrf opened this issue Sep 5, 2019 · 4 comments · Fixed by #8112
Closed
2 of 7 tasks

Gitea returns import path for organization #8095

rutgerbrf opened this issue Sep 5, 2019 · 4 comments · Fixed by #8112
Labels
type/bug
Milestone
1.9.3

Comments

@rutgerbrf
Copy link

rutgerbrf commented Sep 5, 2019 •
edited
Loading

  • Gitea version (or commit ref): 1.9.2
  • Git version: 2.22.0
  • Operating system: Manjaro 18.0.4
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant

Description

To quote:

In module mode in Go 1.13, the go command checks all possible module paths in parallel for the requested package.

Gitea returns a non-valid Git fetch URL for e.g. https://try.gitea.io/test, as seen in the example below. This makes it impossible to use Go modules pulling dependencies from a private Gitea instance, because Go 1.13 expects no clone URL if it is not a valid repository path (see GitLab behavior). This issue is related to golang/go#34075. See that issue for more information.

$ curl https://try.gitea.io/test/?go-get=1  
<!doctype html>
<html>
        <head>
                <meta name="go-import" content="try.gitea.io/test git https://try.gitea.io/test/.git">
                <meta name="go-source" content="try.gitea.io/test _ https://try.gitea.io/test/src/branch/master{/dir} https://try.gitea.io/test/src/branch/master{/dir}/{file}#L{line}">
        </head>
        <body>
                go get try.gitea.io/test
        </body>
</html>

But test is an organization and this information should not be added, as it makes it impossible to retrieve dependencies using go get in Go 1.13.
@rutgerbrf
Copy link
Author

rutgerbrf commented Sep 5, 2019 •
edited
Loading

There is some code which could be used in https://github.com/profects/gitea/tree/fix-go1.13-invalid-import-path, and I will probably create a merge request sometime soon. It would be nice if this issue could be fixed in a 1.9 minor release. The fix in this branch currently works for us, but I have not tried to run the test suite yet.

@lunny
Copy link
Member

lunny commented Sep 5, 2019

@rutgerbrf Please.

@lunny lunny added this to the 1.9.3 milestone Sep 5, 2019
@lunny lunny added the type/bug label Sep 5, 2019
@ghost
Copy link

ghost commented Sep 5, 2019

Just a + here to increase the pressure! ;)

@lunny
Copy link
Member

lunny commented Sep 5, 2019

@rutgerbrf I can confirm that your patch works.

@rutgerbrf rutgerbrf mentioned this issue Sep 5, 2019
Merged
@lunny lunny mentioned this issue Sep 6, 2019
Merged
This was referenced Sep 18, 2019
Closed
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.9.3
Development

Successfully merging a pull request may close this issue.

Fix Go 1.13 private repository go get issue lunny/gitea
2 participants
@lunny @rutgerbrf