-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GOPROXY protocol support #7608
Comments
The benefit when gitea support goproxy protocol but not a third-party:
A goproxy protocol request likes below, there are 5 http requests need to be implemented.
If gitea supports that, the domain refs: btw: |
but problem is that pretty much any domain will have to be reserved username then... |
And what it would do with external package (not a local repo) ? cache them also ? |
@lafriks No. Only the domain gitea itself. Mirrors could be any place because we know they mirrored from. |
@sapk there are two functionality of goproxy protocol. One is for cache, another is for repositories. On go module time, above is also available but provide a direct protocol is better. It will accelerate directly visit because git is too slow for a go module protocol. You can consider this is a go module protocol v2 rather than go get protocol v1. This will not against goproxy, it will only provide repositories via goproxy protocol. |
When I and unknwon begin |
@lunny I understand the speed-up but the trade-off are "big" (blocking some name, adding complexity, ...) compare to someone just setup a goproxy aside. On a side note, I haven't tested but GOPROXY should support a subfolder like GOPROXY=https://myproxy.com/sub-folder. (at least, it support it for file:// url) confirmed and confirmed |
we could set to reserved username |
@sapk @lafriks Yeah. Gitea could implement these package protocols for this instance's repositories (NOT for a cache proxy). The target is different from goproxy or athens . And as what @lafriks said, this should be a first step to support golang, furthermore we can support other language packages protocols. For enterprises' public or private repositories, that will reduce an extra server(goproxies or other languages). Once gitea implemented this and with go 1.13, we can just set |
Highly needed feature |
Fixes #7608 This PR adds a Go package registry usable with the Go proxy protocol. ![grafik](https://github.com/go-gitea/gitea/assets/1666336/328feb5c-3df2-4f9d-8eae-fe3126d14c37)
If gitea could be as a goproxy server and all requested repositories could be stored on a special orgnization. That maybe a good idea.
ref: https://go.dev/ref/mod#goproxy-protocol
The text was updated successfully, but these errors were encountered: