Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide whitespace in comparisons #716

Closed
rugk opened this issue Jan 22, 2017 · 15 comments
Closed

Hide whitespace in comparisons #716

rugk opened this issue Jan 22, 2017 · 15 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@rugk
Copy link
Contributor

rugk commented Jan 22, 2017 •
edited by andreynering
Loading

Similar to GitHub's (AFAIK) new option in comparisons (e.g. pull requests), Gitea should be able to hide the whitespace when doing comparisons (and of course to show it).
There should be a switch in the comparison view.

Upstream issue: gogs/gogs#3795
@lunny lunny added this to the 1.x.x milestone Jan 22, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 22, 2017
@tobias-- tobias-- mentioned this issue Aug 24, 2017
Closed
@andreynering andreynering added the topic/ui Change the appearance of the Gitea UI label Aug 24, 2017
@bobheadxi
Copy link

I think I might have a crack at this

@nemoinho nemoinho mentioned this issue Aug 13, 2018
Merged
@stale
Copy link

stale bot commented Jan 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 26, 2019
@zeripath
Copy link
Contributor

Fixed by #4683

@lafriks lafriks modified the milestones: 1.x.x, 1.6.0 Jan 27, 2019
@PaulBol
Copy link

PaulBol commented Sep 11, 2019

I don't think that the issue is fully addressed. For a PR I see the whitespace dropdown but not for a commit. In fact it took me a while to realize this as I was sure the option existed but couldn't find it - because I was looking at a commit comparison page.

Can the issue be re-opened?

@lunny
Copy link
Member

lunny commented Sep 11, 2019

You could change the options on repository settings.

@PaulBol
Copy link

PaulBol commented Sep 11, 2019

Thanks for your feedback. I didn't find any setting that seems to be related to the commit view. Could you please give me a hint where to look?

@e1fueg0
Copy link

e1fueg0 commented Oct 14, 2019

@lunny I also can't find it, please show.

@e1fueg0
Copy link

e1fueg0 commented Oct 14, 2019

I looked into the code and found out the whitespace ignorance is only implemented for pull requests.
Please can it be implemented for regular commits @lunny ?

@PaulBol
Copy link

PaulBol commented Nov 8, 2019

I must say that I didn't find the option on Github either to ignore whitespace changes on the commit view like b747501. But I'm having troubles to see why the option exists for a pull request and not for a single commit. @rugk initially talked about comparisons in general.

@zeripath zeripath reopened this Nov 9, 2019
@stale stale bot removed the issue/stale label Nov 9, 2019
mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue Nov 9, 2019
@mrsdizzie
Update Github migration test
9182773 
Earlier today go-gitea#716 was reopened which updated the modification time for
an old milestone (1.6.0) that we use in testing with the assumption that
it is old and won't change. This breaks all builds now, so remove this
test since we have others that test the same code and this milestone
will likely be updated again as that issue changes etc...
@mrsdizzie mrsdizzie mentioned this issue Nov 9, 2019
Merged
@lunny
Copy link
Member

lunny commented Nov 9, 2019

@e1fueg0 sorry, I missed this.

guillep2k pushed a commit to guillep2k/gitea that referenced this issue Nov 9, 2019
@mrsdizzie @guillep2k
Update Github migration test
971f3f1 
Earlier today go-gitea#716 was reopened which updated the modification time for
an old milestone (1.6.0) that we use in testing with the assumption that
it is old and won't change. This breaks all builds now, so remove this
test since we have others that test the same code and this milestone
will likely be updated again as that issue changes etc...
guillep2k pushed a commit to guillep2k/gitea that referenced this issue Nov 9, 2019
@mrsdizzie @guillep2k
Update Github migration test
9aa19a6 
Earlier today go-gitea#716 was reopened which updated the modification time for
an old milestone (1.6.0) that we use in testing with the assumption that
it is old and won't change. This breaks all builds now, so remove this
test since we have others that test the same code and this milestone
will likely be updated again as that issue changes etc...
techknowlogick pushed a commit that referenced this issue Nov 9, 2019
@mrsdizzie @techknowlogick
Update Github migration test (#8893)
c541451 
* Update Github migration test

Earlier today #716 was reopened which updated the modification time for
an old milestone (1.6.0) that we use in testing with the assumption that
it is old and won't change. This breaks all builds now, so remove this
test since we have others that test the same code and this milestone
will likely be updated again as that issue changes etc...

* ci
techknowlogick pushed a commit that referenced this issue Nov 9, 2019
@guillep2k @techknowlogick
Update Github migration test (#8897)
0b91aaf 
Earlier today #716 was reopened which updated the modification time for
an old milestone (1.6.0) that we use in testing with the assumption that
it is old and won't change. This breaks all builds now, so remove this
test since we have others that test the same code and this milestone
will likely be updated again as that issue changes etc...
techknowlogick pushed a commit that referenced this issue Nov 9, 2019
@guillep2k @techknowlogick
Update Github migration test (#8896)
ca69ded 
Earlier today #716 was reopened which updated the modification time for
an old milestone (1.6.0) that we use in testing with the assumption that
it is old and won't change. This breaks all builds now, so remove this
test since we have others that test the same code and this milestone
will likely be updated again as that issue changes etc...
@stale
Copy link

stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 8, 2020
@zeripath zeripath added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 8, 2020
@stale stale bot removed the issue/stale label Jan 8, 2020
@maximilize
Copy link

It seems like this feature is already implemented. However, it would be nice if the last selected option like Ignore changes in amount of whitespaces is remembered.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 27, 2022 •
edited
Loading

It seems like this feature is already implemented. However, it would be nice if the last selected option like Ignore changes in amount of whitespaces is remembered.

It is in latest 1.17

@wxiaoguang wxiaoguang modified the milestones: 1.6.0, 1.17.0 Apr 27, 2022
@wxiaoguang wxiaoguang reopened this Apr 27, 2022
@wxiaoguang wxiaoguang removed this from the 1.17.0 milestone Apr 27, 2022
@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Jun 5, 2022

@wxiaoguang Why was this reopened?

@wxiaoguang
Copy link
Contributor

Oh yes, it can be closed. 😊

If there is anything missing, feel free to reopen.

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests