Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static embed files should not be decompress and compress #7107

Closed
lunny opened this issue Jun 3, 2019 · 1 comment · Fixed by #7109
Closed

Static embed files should not be decompress and compress #7107

lunny opened this issue Jun 3, 2019 · 1 comment · Fixed by #7109
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@lunny
Copy link
Member

lunny commented Jun 3, 2019

As I said on #7080 (comment) , currently we use http.FileSystem to open a embed file on memory, that will decompress from a gzip compressed memory file and then we serve it as a http request and compress it(maybe). So I think that we can provide the gzip compressed file directly.

From vfsgen, we could detect if the File is httpgzip.NotWorthGzipCompressing or httpgzip.GzipByter to do that.
@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 3, 2019
@stale
Copy link

stale bot commented Aug 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 2, 2019
@lafriks lafriks added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 2, 2019
@stale stale bot removed the issue/stale label Aug 2, 2019
@lunny lunny mentioned this issue Aug 3, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve vfsgen to not unzip bindata files but send to browser directly lunny/gitea
2 participants
@lunny @lafriks