Allow colon in closing issue from commit message

[znegva]

• Gitea version (or commit ref): 1.6.1
• Git version: --
• Operating system: --
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Gitea-Issues can be closed, reopened or referenced in commit messages.
The same keywords as in github are used, see here.
Githubs description of the feature is described here.

Inside github it is possible to use a colon between keyword and issue-number, eg

Fixed the critical bug
closes: #123

This is not possible with gitea, only keywords directly followed by the issue number are recognised:

Fixed the critical bug
closes #123

It would be great if an optional colon : could be supported.
If I read the source code correctly this should be feasible by slightly extending the regex used to detect the keywords.

Depending on your understanding, communication with the issue tracker is additional information that is not necessarily related to the actual commit.
Especially if you use the commit messages in addition in other ways (e.g. to create documentation or changelogs) issue-related stuff is often unimportant.
The ability to structure issue references more clearly makes it easier to ignore these references where they are not needed.

Additional Infos

• Linux Kernel Team has Commit Conventions that use the described form to close bugs/issues
• trailers in git commit messages

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[guillep2k]

Fixed by #7207?