Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move lfs to S3 (minio) #5530

Closed
projectDaemon opened this issue Dec 12, 2018 · 11 comments · Fixed by #12518
Closed

move lfs to S3 (minio) #5530

projectDaemon opened this issue Dec 12, 2018 · 11 comments · Fixed by #12518
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@projectDaemon
Copy link

It would be nice to have minio backend for lfs

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 12, 2018
@lunny lunny added this to the 1.x.x milestone Dec 12, 2018
@sapk
Copy link
Member

sapk commented Dec 13, 2018

Is it to store lfs data via gitea in minio or use minio as external lfs backend ?

I haven't tested but external lfs backend can be set manually via :

git config -f .lfsconfig lfs.url https://my_other_server.example.com/foo/bar/info/lfs
git add .lfsconfig

@lunny
Copy link
Member

lunny commented Dec 13, 2018

I think he means store lfs files to s3 storage server but not local disk.

@stale
Copy link

stale bot commented Feb 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 11, 2019
@lafriks lafriks added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 11, 2019
@stale stale bot removed the issue/stale label Feb 11, 2019
@segevfiner
Copy link
Contributor

Rather than the minio library, which only supports S3 like providers, we can choose a library that supports multiple different cloud storage services (And S3 clones), wrapping it's configuration in Gitea's configuration. And if that library also supports local files, even better, as there will be no need to maintain two implementations. The local file implementation will have to scale properly, that is, support splitting the objects into subdirectories as currently done. And there is also the issue of migrating existing data if needed.

This needs to be something that the Gitea developers are comfortable using and having a proper license. Here are a few options:

(There may be more)

The configuration format for this is highly affected by the chosen library.

There is also.the issue of what key format to use. Cloud storage doesn't need the subdirectory splitting trick, though it probably doesn't hurt them either, and still using it there might allow easier migration using a simple recursive cp to the cloud storage provider.

I would love to hear Gitea's maintainers take on this.

@clarfonthey
Copy link
Contributor

I agree that having some sort of object storage support for LFS would be really nice. S3-compatible APIs are one option, but really, having a generic API that allows us to plug in any cloud provider would be better.

@i0x71
Copy link

i0x71 commented Apr 27, 2020

Was there any progress on this ?
This would be a killer feature.
If you could store all git data on minio that would be even better.
Gitea combined with minio distributed amd fault tolerant setup would be awesome.

@jolheiser
Copy link
Member

I believe this would be taken care of by #9567

@i0x71
Copy link

i0x71 commented Apr 27, 2020

Awesome, thanks

@colorfulberry
Copy link
Contributor

colorfulberry commented May 18, 2020

How about this going? Any plan to merge or not

@lunny
Copy link
Member

lunny commented May 18, 2020

See my PR #11387

@colorfulberry
Copy link
Contributor

@lunny Cool, Thanks

@lunny lunny modified the milestones: 1.x.x, 1.13.0 Sep 3, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants