Custom event > releases payload does not contain secret

[AuspeXeu]

• Gitea version (or commit ref): 1.5.2
• Git version: 2.9.3
• Operating system: CentOS
• Database:
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Not relevant

Description

When setting up a gitea webhook, one can provide a secret that is supposed to be included in the delivered POST application/json payload. This works fine for "Push Events", however when choosing "Custom Events..." and selecting "Releases", this secret is not included in the payload anymore.

[AuspeXeu]

I just tested the latest version 1.6.0-rc2 and it seems like this issue is still not resolved. Now, if I trigger a test delivery for a custom event of the type release, no request is queued whatsoever.

Edit: I tried this on the demo instance with the following settings.

As you can see here, no requests are received http://requestbin.net/r/1oa26911?inspect

[HoffmannP]

Could you explain "trigger a test delivery"? I tried to retrace your steps but couldn't find the same error

[AuspeXeu]

I simply press the "Test Delivery" button :)

[HoffmannP]

Okey, but it looks to me as if the TestDelivery is always executing a push event. If your webhook only acts on releases it will not be triggered.

gitea/routers/repo/webhook.go

Line 677 in 4c1f1f9

if err := models.PrepareWebhook(w, ctx.Repo.Repository, models.HookEventPush, p); err != nil {

Perhaps the button should be renamed to "Test push event"

[AuspeXeu]

My intuition was that the button tests whatever hook is specified at the top?!
Anyways, I had to put a new request bin, here the link to inspect it http://requestbin.net/r/wy4b3rwy?inspect

I pushed a tag (release) to the repository under https://try.gitea.io/test1337/Hooktest and it did not trigger a request to the request bin. So something seems to be broken, no?

Edit: Okay, I just figure out what the problem is. I am actually not sure whether it's a problem or by design. But there is definitely some confusion. If I create a tag and push it, the tag appears under releases in the repository, however the custom event hook is not triggered. BUT, if I create a release via the webinterface, the hook is triggered.

So here is some inconstancy. Either a normal tag should not be a release or it is considered a release and it should trigger the hook.

[lafriks]

@AuspeXeu tag without release in release list page is displayed differently