-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL encoding lost upon round trip through login #4475
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
It looks like this is still occurring. I don't think the issue should be closed. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
redirect_to holds a value that we want to redirect back to after login. This value can be a path with intentonally escaped values and we should not unescape it. Fixes go-gitea#4475
redirect_to holds a value that we want to redirect back to after login. This value can be a path with intentonally escaped values and we should not unescape it. Fixes #4475
redirect_to holds a value that we want to redirect back to after login. This value can be a path with intentonally escaped values and we should not unescape it. Fixes go-gitea#4475
If you are logged out and at a url containing an encoded
#
(i.e.,%23
), and then you click 'sign in' and complete the sign-in, you end up at the original url but with an actual#
in it instead of a%23
.In the first navigation (upon clicking 'sign in') you are brought to a page with a
?redirect_to=
value containing%2523
, which seems correct. Theset-cookie
header that's returned also contains%2523
, which I think is correct. It's not going through the layer of query param encoding, but it is going through the layer of cookie header encoding.In the second navigation (upon entering your username/password and clicking 'sign in'), the redirect from the server has a
location
header that includes a#
though, which is definitely incorrect.This is on Gitea version 1e2da5d
The text was updated successfully, but these errors were encountered: