Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook POST data doesn't pass added/modified/removed info in commits section #4313

Closed
2 of 7 tasks
p4a6i opened this issue Jun 25, 2018 · 4 comments · Fixed by #7671
Closed
2 of 7 tasks

Webhook POST data doesn't pass added/modified/removed info in commits section #4313

p4a6i opened this issue Jun 25, 2018 · 4 comments · Fixed by #7671
Assignees
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Milestone

Comments

@p4a6i
Copy link

p4a6i commented Jun 25, 2018

  • Gitea version (or commit ref): 1.4.2
  • Git version: 2.13
  • Operating system: Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io: (URL is down at the time of issue)
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

I created a web hook and pushed a change (Tried with both content types json and xml)
When a looked at payload sent by gitea in commit section
"commits": [
{
"id": "bffeb74224043ba2feb48d137756c8a9331c449a",
"message": "Webhooks Yay!",
"url": "http://localhost:3000/gitea/webhooks/commit/bffeb74224043ba2feb48d137756c8a9331c449a",
"author": {
"name": "Gitea",
"email": "someone@gitea.io",
"username": "gitea"
},
"committer": {
"name": "Gitea",
"email": "someone@gitea.io",
"username": "gitea"
},
"timestamp": "2017-03-13T13:52:11-04:00"
}
]

there is no added/modified/removed info

"commits": [
{
"id": "bffeb74224043ba2feb48d137756c8a9331c449a",
"message": "Webhooks Yay!",
"url": "http://localhost:3000/gitea/webhooks/commit/bffeb74224043ba2feb48d137756c8a9331c449a",
"author": {
"name": "Gitea",
"email": "someone@gitea.io",
"username": "gitea"
},
"committer": {
"name": "Gitea",
"email": "someone@gitea.io",
"username": "gitea"
},
"timestamp": "2017-03-13T13:52:11-04:00"
}
"added": ...

]

@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 26, 2018
@tvvignesh
Copy link

@lunny First of all thanks for making Gitea awesome. Is there any timeline on when this will get introduced? This is very critical for our CI/CD pipeline - this works in Gogs but Gogs has lot of missing features. Is it possible for you to get the code from Gogs and incorporate it here? Thanks.

@lunny
Copy link
Member

lunny commented Dec 29, 2018

I will investigate this and if it's not very difficult, I will send a PR later.

@lunny lunny self-assigned this Dec 29, 2018
@tvvignesh
Copy link

@lunny Thanks a lot for your quick reply. Will wait for the release. Love Gitea!

@stale
Copy link

stale bot commented Feb 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 27, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 27, 2019
@lunny lunny added this to the 1.10.0 milestone Aug 26, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants