Breaking change in a 'patch' release #35847
Description
Description
I've been trying to upgrade my Gitea instance which was on 1.23.3. I've narrowed down the breaking change to 1.23.5 as 1.23.4 is the last version that works. Specifically, it now fails with this:
server-1 | Server listening on 0.0.0.0 port 22.
server-1 | 2025/11/04 00:29:47 ...es/setting/server.go:218:loadServerFrom() [F] ACME Email is not set (ACME_EMAIL).
server-1 | Received signal 15; terminating.
Okay, my app.ini indeed does not contain an ACME_EMAIL and this alone is probably already a bug, but let's say I do provide one, now it fails with this:
server-1 | 1.7622454579789722e+09 warn acme_client HTTP request failed; retrying {"url": "https:", "error": "performing request: Get \"https:\": http: no Host in request URL"}
server-1 | 1.762245457979327e+09 error obtain could not get certificate from issuer {"identifier": "redacted", "issuer": "", "error": "registering account [mailto:redacted] with server: provisioning client: performing request: Get \"https:\": http: no Host in request URL"}
Gitea Version
1.23.5
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Docker
services:
server:
image: docker.io/gitea/gitea:1.23.5
environment:
- GITEA__database__DB_TYPE=postgres
- GITEA__database__HOST=db:5432
- GITEA__database__NAME=gitea
- GITEA__database__USER=gitea
- GITEA__database__PASSWD=gitea
#restart: always
volumes:
- ./data:/data
- /etc/timezone:/etc/timezone:ro
- /etc/localtime:/etc/localtime:ro
ports:
- "22:2222"
- "80:3080"
- "443:3000"
depends_on:
- db
db:
image: docker.io/library/postgres:14
restart: always
environment:
- POSTGRES_USER=gitea
- POSTGRES_PASSWORD=gitea
- POSTGRES_DB=gitea
volumes:
- ./postgres:/var/lib/postgresql/dataDatabase
PostgreSQL