Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET vs POST swagger.json #3501

Closed
flyinprogrammer opened this issue Feb 13, 2018 · 4 comments
Closed

GET vs POST swagger.json #3501

flyinprogrammer opened this issue Feb 13, 2018 · 4 comments
Labels

Comments

@flyinprogrammer
Copy link

Was this file generated?

"get": {

It seems this is using that json file:
https://try.gitea.io/api/swagger#/

But then what's going on between these three methods?
https://github.com/go-gitea/gitea/blob/master/routers/api/v1/repo/release.go#L16
https://github.com/go-gitea/gitea/blob/master/routers/api/v1/repo/release.go#L59
https://github.com/go-gitea/gitea/blob/master/routers/api/v1/repo/release.go#L99

And why is the swagger json wrong?
I'm happy to submit a patch - I just wasn't quite sure what was going on!

@lunny lunny added the type/bug label Feb 17, 2018
@captn3m0
Copy link

👍

image

However, this seems to be fixed on try.gitea.io somehow?

image

I'm running 1.4.0+3-g641d481 which shouldn't be far from master.

@sapk
Copy link
Member

sapk commented Apr 17, 2018

It was added/fixed by #3478 but it hadn't be backported to v1.4 branch since it is a new feature. I submitted #3811 to be sure that swagger is generated in PR that need it.

@stale
Copy link

stale bot commented Jan 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Jan 28, 2019
@adelowo
Copy link
Member

adelowo commented Jan 28, 2019

I believe this can be closed

@stale stale bot removed the issue/stale label Jan 28, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants