repo.CompareDiff: 500 internal server error

[phoedos]

Description

Hi guys!
Face with issues during PR view

2025/04/01 12:18:49 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/master...DIR-1998-subtitle-A for xIP:0, 500 Internal Server Error in 38750.5ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/02 10:50:46 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo for xIP:0, 500 Internal Server Error in 29.0ms @ context/repo.go:866(web.registerRoutes.RepoRef.RepoRefByType)
2025/04/03 12:25:14 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/master...DIR-1980-A for xIP:0, 500 Internal Server Error in 27424.2ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:25:30 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/master...DIR-1980-A for xIP:0, 500 Internal Server Error in 16279.8ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:25:38 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/master...DIR-1980-A for xIP:0, 500 Internal Server Error in 7348.0ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:28:33 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/release/1.5.65...DIR-1368 for xIP:0, 500 Internal Server Error in 33111.7ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:28:43 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/release/1.5.65...DIR-1368 for xIP:0, 500 Internal Server Error in 2446.8ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:30:46 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/master...DIR-1368 for xIP:0, 500 Internal Server Error in 101766.9ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:34:37 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/release/1.5.65...DIR-1368 for xIP:0, 500 Internal Server Error in 213961.1ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:34:51 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/release/1.5.65...DIR-1368 for xIP:0, 500 Internal Server Error in 5297.3ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:36:52 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/release/1.5.65...DIR-1368 for xIP:0, 500 Internal Server Error in 7826.4ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:36:57 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/release/1.5.65...DIR-1368 for xIP:0, 500 Internal Server Error in 4840.6ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:37:05 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/release/1.5.65...DIR-1368 for xIP:0, 500 Internal Server Error in 5399.1ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:38:00 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/release/1.5.65...DIR-1368 for xIP:0, 500 Internal Server Error in 36287.4ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:38:16 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/release/1.5.65...DIR-1368 for xIP:0, 500 Internal Server Error in 16339.2ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:40:09 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/release/1.5.65...DIR-1368 for xIP:0, 500 Internal Server Error in 112441.3ms @ repo/compare.go:708(repo.CompareDiff)
2025/04/03 12:40:17 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/DIR-1368..release/1.5.65 for xIP:0, 500 Internal Server Error in 120679.9ms @ repo/compare.go:708(repo.CompareDiff)

e.g. developer approve PRs from branch DIR-1368 to release branch release/1.5.65 and face with 500
xIP is a masked IP

Gitea Version

1.23.5

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

dockerized 1.23.5 + postgresql 17.2

Database

PostgreSQL

[wxiaoguang]

Could you try to use 1.23-nightly? Maybe it has been fixed.

• https://dl.gitea.com/gitea/1.23-nightly/
• https://hub.docker.com/r/gitea/gitea/tags?name=1.23-nightly

[wxiaoguang]

By the way, if there are 500 errors, there should be other error logs. It seems that you didn't collect the related error logs in the report.

[phoedos]

dear @wxiaoguang today I will try 1.23.6
here is a previous line before error with 12:40:09 and 12:40:17 timestamp:

2025/04/03 12:40:09 .../web/repo/compare.go:629:PrepareCompareDiff() [E] GetDiffRangeWithWhitespaceBehavior: context canceled
2025/04/03 12:40:09 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepol/compare/release/1.5.65...DIR-1368 for xxIP:0, 500 Internal Server Error in 112441.3ms @ repo/compare.go:708(repo.CompareDiff)

2025/04/03 12:40:17 .../web/repo/compare.go:629:PrepareCompareDiff() [E] GetDiffRangeWithWhitespaceBehavior: context canceled
2025/04/03 12:40:17 ...eb/routing/logger.go:102:func1() [I] router: completed GET /MYORG/myrepo/compare/DIR-1368..release/1.5.65 for xxIP:0, 500 Internal Server Error in 120679.9ms @ repo/compare.go:708(repo.CompareDiff)

[wxiaoguang]

I think it duplicates with #31600 and should have been fixed in 1.23 nightly by #34033

[wxiaoguang]

today I will try 1.23.6

By the way, the fix is not in 1.23.6, please use 1.23-nightly (it will be 1.23.7 soon)

• https://dl.gitea.com/gitea/1.23-nightly/
• https://hub.docker.com/r/gitea/gitea/tags?name=1.23-nightly

[phoedos]

The issue is solved after 1.23.7 upgrade. Thank you!