Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong documentation link on webhooks repository settings page #3291

Closed
Exagone313 opened this issue Jan 3, 2018 · 1 comment
Closed

Wrong documentation link on webhooks repository settings page #3291

Exagone313 opened this issue Jan 3, 2018 · 1 comment
Labels
type/docs This PR mainly updates/creates documentation
Milestone

Comments

@Exagone313
Copy link
Contributor

  • Gitea version (or commit ref): v1.3.2 (latest master is concerned too)

Description

When editing repository settings, on the webhooks page, there is a link that says:

"Learn more in the webhooks guide."

The link is defined here:

ctx.Data["Description"] = ctx.Tr("repo.settings.hooks_desc", "https://godoc.org/code.gitea.io/sdk/gitea")

Used here in (en-US) locale:
settings.hooks_desc = Webhooks are much like basic HTTP POST event triggers. Whenever something occurs in Gitea, we will send a notification to the target host. Learn more in the <a target="_blank" rel="noopener" href="%s">webhooks guide</a>.

I think the correct link is https://docs.gitea.io/en-us/webhooks/ but notice that this link may be localized, and I don't know how to deal with that (this would need to edit every locale accordingly I guess, if you don't have particular code for this, but maybe linking to en-us link is fine).

I'm going to submit a PR for changing this link like I described here.

Exagone313 added a commit to Exagone313/gitea that referenced this issue Jan 3, 2018
Signed-off-by: Elouan Martinet <exa@elou.world>
appleboy pushed a commit that referenced this issue Jan 3, 2018
Signed-off-by: Elouan Martinet <exa@elou.world>
@lunny lunny added this to the 1.4.0 milestone Jan 4, 2018
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Jan 4, 2018
@lunny
Copy link
Member

lunny commented Jan 4, 2018

resolved by #3292

@lunny lunny closed this as completed Jan 4, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

No branches or pull requests

2 participants