Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications remains after repository or issue deleted. #3105

Closed
lunny opened this issue Dec 7, 2017 · 3 comments · Fixed by #5506
Closed

Notifications remains after repository or issue deleted. #3105

lunny opened this issue Dec 7, 2017 · 3 comments · Fixed by #5506
Labels
type/bug
Milestone
1.6.2

Comments

@lunny
Copy link
Member

lunny commented Dec 7, 2017

image
@lunny lunny added the type/bug label Dec 7, 2017
@lunny lunny added this to the 1.x.x milestone Dec 7, 2017
@ethantkoenig
Copy link
Member

I would like to make a friendly observation that we wouldn't have this problem if we used foreign keys.

@svarlamov
Copy link
Contributor

@ethantkoenig I found it really crazy that Gitea doesn't use FKs after digging into the code the last few days... May I ask why this is the case?

@lunny
Copy link
Member Author

lunny commented Dec 7, 2017

@ethantkoenig @svarlamov I didn't implement FK in xorm.

@ghost ghost mentioned this issue Jul 10, 2018
Closed
7 tasks
@lunny lunny changed the title Read messages on notifications should be deleted when issue deleted. Notifications remains after repository or issue deleted. Aug 1, 2018
@lunny lunny modified the milestones: 1.x.x, 1.6.2 Dec 9, 2018
@lunny lunny mentioned this issue Dec 9, 2018
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.6.2
Development

Successfully merging a pull request may close this issue.

fix forgot deletion of notification when delete repository lunny/gitea
3 participants
@lunny @ethantkoenig @svarlamov