Dash in URL breaks hyperlink parsing #3095
Labels
Comments
|
Is there any update on if this is being looked into? Or when a fix might be implemented? |
|
@lukewatts This PR #3354 could possible solve this |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions. |
|
Since #3354 merged, I'll close this one. Please feel free to reopen it. |
mrsdizzie
added a commit
to mrsdizzie/gitea
that referenced
this issue
Mar 7, 2019
Rather than maintaining a complicated regex to match URLs for autolinking, gitea can use this existing go library that takes care of the matching with very little code change to gitea itself. After spending a while trying to find the perfect regex for all cases this library still works better as it is more flexible than a single regex ever will be. This will also fix the following issues: go-gitea#5844 go-gitea#3095 go-gitea#3381 This passes all our current tests and I've added new ones mentioned in those issues as well.
techknowlogick
pushed a commit
that referenced
this issue
Mar 7, 2019
* Replace linkRegex with xurls library Rather than maintaining a complicated regex to match URLs for autolinking, gitea can use this existing go library that takes care of the matching with very little code change to gitea itself. After spending a while trying to find the perfect regex for all cases this library still works better as it is more flexible than a single regex ever will be. This will also fix the following issues: #5844 #3095 #3381 This passes all our current tests and I've added new ones mentioned in those issues as well. * Use xurls.StrictMatchingScheme instead of xurls.Strict This is much faster and we only care about https? links to preserve existing behavior.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
When posting an issue by cut-n-pasting a URL like https://example.com/something/my-link the URL parsing works and I get a pretty hyperlink after posting. However, this url https://sample.example.com/:i:/p/foobar/helloworld-foo?abc=123 breaks. Ie., the link is only the
https://sample.example.com/:i:/p/foobar/helloworldpart, whereas-foo?abc=123just looks like normal text and when I click on the part that got recognized as a link, it directs me without the-foo?abc=123part -- which is not where I wanted to go!I have this problem quite often when posting links to screenshots in Gitea (because the image upload is very painful, ref #3032)... But even now that I'm posting URLs, it's still not happy... 😢
Screenshots
The text was updated successfully, but these errors were encountered: