Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code markup style regression #30292

Closed
KN4CK3R opened this issue Apr 5, 2024 · 4 comments · Fixed by #30298
Closed

Code markup style regression #30292

KN4CK3R opened this issue Apr 5, 2024 · 4 comments · Fixed by #30298
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@KN4CK3R
Copy link
Member

KN4CK3R commented Apr 5, 2024 •
edited
Loading

The inner background is new. Don't know if that is intended but here it looks strange:
grafik
@KN4CK3R KN4CK3R added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 5, 2024
@wxiaoguang
Copy link
Contributor

Related to Render embedded code preview by permlink in markdown #30234 ?

It changed some "markup code" styles.

@wxiaoguang
Copy link
Contributor

Well, it is, there is a really annoying CSS style overriding game.

@wxiaoguang wxiaoguang mentioned this issue Apr 5, 2024
Closed
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 5, 2024 •
edited
Loading

-> Refactor markup code block styles #30294

-> Fix code block style for code preview #30298

@wxiaoguang

This comment was marked as resolved.

Sign in to view
@silverwind silverwind mentioned this issue Apr 5, 2024
Merged
@wxiaoguang wxiaoguang mentioned this issue Apr 5, 2024
Merged
wxiaoguang added a commit that referenced this issue Apr 6, 2024
@wxiaoguang
Fix code block style for code preview (#30298)
7396172 
Fix #30292

To avoid unnecessary style overriding, use "div" instead of "code"
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Apr 6, 2024
@wxiaoguang @GiteaBot
Fix code block style for code preview (go-gitea#30298)
48b610a 
Fix go-gitea#30292

To avoid unnecessary style overriding, use "div" instead of "code"
@GiteaBot GiteaBot mentioned this issue Apr 6, 2024
Merged
wxiaoguang added a commit that referenced this issue Apr 6, 2024
@GiteaBot @wxiaoguang
Fix code block style for code preview (#30298) (#30306)
45e8a88 
Backport #30298 by wxiaoguang

Fix #30292

To avoid unnecessary style overriding, use "div" instead of "code"

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
AvengerMoJo pushed a commit to AvengerMoJo/gitea that referenced this issue Apr 8, 2024
@wxiaoguang @AvengerMoJo
Fix code block style for code preview (go-gitea#30298)
66e78f5 
Fix go-gitea#30292

To avoid unnecessary style overriding, use "div" instead of "code"
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
2 participants
@KN4CK3R @wxiaoguang