Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect after merge pull commit isn't working #28828

Closed
somera opened this issue Jan 17, 2024 · 16 comments
Closed

Redirect after merge pull commit isn't working #28828

somera opened this issue Jan 17, 2024 · 16 comments
Labels

Comments

@somera
Copy link

somera commented Jan 17, 2024

Description

When I mere a pull requests

image

the redirect isn't working. In Chrome I see only this

image

in 1.21.3 it worked. I was redirected to the result page.

Gitea Version

1.21.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.43.0

Operating System

Ubuntu 22.04.3 LTS x86_64

How are you running Gitea?

Downloaded gitea-1.21.4-linux-amd64

Database

PostgreSQL

@somera
Copy link
Author

somera commented Jan 17, 2024

Same problem with FF.

@delvh
Copy link
Member

delvh commented Jan 17, 2024

Do you have JS enabled?

@somera
Copy link
Author

somera commented Jan 17, 2024

Yes. Cause and I didn't change nothing between the update from 1.21.3 to 1.21.4. My last pull merge with 1.21.3 was ~10 days ago without any issues. And after the update to 1.21.4 I see only the redirect json in Chrome and FF.

@somera
Copy link
Author

somera commented Jan 17, 2024

The merge is working. But the redirect after isn't -> something changes here.

@delvh
Copy link
Member

delvh commented Jan 17, 2024

Sounds like #28140 iintroduced a regression then…

@delvh
Copy link
Member

delvh commented Jan 17, 2024

What happens if you clear your browser cache? Does the issue persist then?

@somera
Copy link
Author

somera commented Jan 17, 2024

What happens if you clear your browser cache? Does the issue persist then?

Isn't working. I use gitea only with chrome. And for testing I cleared browser cache too.

I used FF only to check the issue. Cause I don't use FF for gitea.

Can you reproduce this issue on your gitea instance?

@lunny
Copy link
Member

lunny commented Jan 17, 2024

Sounds like #28140 iintroduced a regression then…

Maybe related with https://github.com/go-gitea/gitea/pull/28140/files#r1399519508

@somera
Copy link
Author

somera commented Jan 18, 2024

@lunny will be this fixed in 1.21.5?

@lunny
Copy link
Member

lunny commented Jan 18, 2024

If we can fix it, I think it's very possible. But I cannot reproduce this on my local machine. I'm using FF.

@somera
Copy link
Author

somera commented Jan 18, 2024

I have same problem with FF 121.0.1.

@somera
Copy link
Author

somera commented Jan 21, 2024

Same problem with Edge.

@somera
Copy link
Author

somera commented Jan 27, 2024

If we can fix it, I think it's very possible. But I cannot reproduce this on my local machine. I'm using FF.

Any updates here? I can't be the only one with the problem.

I tested it on Windows and Linux.

@somera
Copy link
Author

somera commented Feb 1, 2024

Same problem in 1.21.5

@somera
Copy link
Author

somera commented Feb 4, 2024

I found the problem.

It's an Layer-8 problem!!!

After upgrade to 1.21.4 and 1.21.5 I forgot to compile the release cause I need the public folder for my Nginx proxy. After I did it now it work's. Now I updated my todo's for the next gitea updates -> checkout the release tag, compile it and copy the public folder to nginx proxy.

Mea culpa.

@somera somera closed this as completed Feb 4, 2024
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants