Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent button size on the team web page #27745

Closed
lng2020 opened this issue Oct 23, 2023 · 7 comments
Closed

Inconsistent button size on the team web page #27745

lng2020 opened this issue Oct 23, 2023 · 7 comments
Assignees
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@lng2020
Copy link
Member

lng2020 commented Oct 23, 2023

Description

There are two bugs.
Left side: the first button is selected by a class because he is the direct child of attached.header, while the second button is wrapped by a form class.
Right side: the class of join is wrong. It should be tiny instead of small.

Screenshots

two_button

Gitea Version

latest codebase

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

No response

Browser Version

none

@lng2020 lng2020 added type/bug topic/ui Change the appearance of the Gitea UI labels Oct 23, 2023
@lng2020 lng2020 changed the title inconsistent button size on the team web page Inconsistent button size on the team web page Oct 23, 2023
@Virtual4087
Copy link

I'd like to work on this issue if you can instruct me how to reproduce it.

@lng2020
Copy link
Member Author

lng2020 commented Oct 23, 2023

It's on the web page. You don't need to reproduce it...
The first one probably required some familiarity with the CSS style in Gitea. If you directly change the class style, It may result in some side effects.

@Pratham271
Copy link

I can work on this.

@silverwind
Copy link
Member

#27632 sounds related but it's not because neither button are dropdowns in those screenshots.

@wxiaoguang
Copy link
Contributor

#27632 sounds related but it's not because neither button are dropdowns in those screenshots.

Nope, not related.

The problem is the button styles were polluted by .ui.right>.button, but another button is in <form>

@wxiaoguang
Copy link
Contributor

Fixed by: Fix button size in "attached header right" #28770

Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

No branches or pull requests

5 participants