Skip to content

Dublicate AppSubUrl in context_menu template #26060

Closed
@ghost

Description

Description

"Copy Link" in templates/repo/issue/view_content/context_menu.tmpl is constructed this way: data-clipboard-text="{{AppSubUrl}}{{$referenceUrl}}". It seems that {{AppSubUrl}} is redundant:

  • $referenceUrl -> .ctxData.Issue.Link -> func (issue *Issue) Link() string
  • func (issue *Issue) Link() string-> fmt.Sprintf("%s/%s/%d", issue.Repo.Link(), path, issue.Index)
  • issue.Repo.Link() -> setting.AppSubURL + "/" + url.PathEscape(repo.OwnerName) + "/" + url.PathEscape(repo.Name)

As you can see there is already AppSubURL in referenceUrl so it looks like that it should be removed from the template.

Gitea Version

1.20

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

SQLite

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions