Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue dependencies without user rights #25837

Closed
bauermarkus opened this issue Jul 11, 2023 · 7 comments · Fixed by #27736
Closed

Issue dependencies without user rights #25837

bauermarkus opened this issue Jul 11, 2023 · 7 comments · Fixed by #27736
Labels

Comments

@bauermarkus
Copy link

Description

When I create more than one dependence, I am not allowed to view the issue through the other issue.

Maybe this is an intended feature, but if, I don't understand this

Side note: I am using a German version, the pop up is using English

Gitea Version

1.20.0-rc1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

No response

How are you running Gitea?

Docker

Database

SQLite

@lunny
Copy link
Member

lunny commented Jul 14, 2023

The languages' switching because maybe the german hasn't translate this string.

@bauermarkus
Copy link
Author

@lunny I guess so too, that's why it's just a side note

Is the rest a bug or intended behaviour?

@arswarog
Copy link

I have save question, I don't undestand it's feature or bug

@lunny
Copy link
Member

lunny commented Oct 11, 2023

I think it's not a bug but an edge problem and no ideal resolution to fix it currently. Assume you are a plain user of this repository and issue but this issue depends on another private repository's issue but you have no permission but some others have the permissions to that dependencies issues.

@Gr3q
Copy link

Gr3q commented Oct 12, 2023

I have the same issue, it doesn't matter in which order the dependencies are only the first is not locked, the rest are. I can access all dependencies just fine, they are in the same repo.

If I would add these dependencies in a different order and a different PR would end up in first place that would not be locked either.

Also ignoring the obvious css issue.

image

@Renari
Copy link

Renari commented Oct 24, 2023

This is most certainly a bug, considering you can just go to the issues tab of the same repository and see the issues that are locked. Furthermore if you have multiple issues blocked by a single other issue it will only show a single entry of the list of issues blocking it.

@bauermarkus
Copy link
Author

I would like to have it classified as a bug, as it is really annoying and brings the feature to almost uselessness

@lunny lunny closed this as completed in 9b59af3 Jan 12, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Jan 12, 2024
Fix go-gitea#27722 
Fix go-gitea#27357
Fix go-gitea#25837 
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
![I U1AT{GNFY3
1HZ`6L{(2L](https://github.com/go-gitea/gitea/assets/70063547/79acd02a-a567-4316-ae0d-11c6461becf1)
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.

![UARFPXRGGZQFB7J$2`R}5_R](https://github.com/go-gitea/gitea/assets/70063547/f21cff0f-d9ac-4ce4-ae4d-adffc98ecd99)
lafriks pushed a commit that referenced this issue Jan 12, 2024
Backport #27736 by @lng2020

Fix #27722 
Fix #27357
Fix #25837 
Fix #28732 
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
![I U1AT{GNFY3
1HZ`6L{(2L](https://github.com/go-gitea/gitea/assets/70063547/79acd02a-a567-4316-ae0d-11c6461becf1)
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.

![UARFPXRGGZQFB7J$2`R}5_R](https://github.com/go-gitea/gitea/assets/70063547/f21cff0f-d9ac-4ce4-ae4d-adffc98ecd99)

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this issue Jan 17, 2024
Fix go-gitea#27722 
Fix go-gitea#27357
Fix go-gitea#25837 
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
![I U1AT{GNFY3
1HZ`6L{(2L](https://github.com/go-gitea/gitea/assets/70063547/79acd02a-a567-4316-ae0d-11c6461becf1)
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.

![UARFPXRGGZQFB7J$2`R}5_R](https://github.com/go-gitea/gitea/assets/70063547/f21cff0f-d9ac-4ce4-ae4d-adffc98ecd99)
silverwind pushed a commit to silverwind/gitea that referenced this issue Feb 20, 2024
Fix go-gitea#27722 
Fix go-gitea#27357
Fix go-gitea#25837 
1. Fix the typo `BlockingByDependenciesNotPermitted`, which causes the
`not permitted message` not to show. The correct one is `Blocking` or
`BlockedBy`
2. Rewrite the perm check. The perm check uses a very tricky way to
avoid duplicate checks for a slice of issues, which is confusing. In
fact, it's also the reason causing the bug. It uses `lastRepoID` and
`lastPerm` to avoid duplicate checks, but forgets to assign the
`lastPerm` at the end of the code block. So I rewrote this to avoid this
trick.
![I U1AT{GNFY3
1HZ`6L{(2L](https://github.com/go-gitea/gitea/assets/70063547/79acd02a-a567-4316-ae0d-11c6461becf1)
3. It also reuses the `blocks` slice, which is even more confusing. So I
rewrote this too.

![UARFPXRGGZQFB7J$2`R}5_R](https://github.com/go-gitea/gitea/assets/70063547/f21cff0f-d9ac-4ce4-ae4d-adffc98ecd99)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants