[CI] action triggered by push is displayed under PR

[harryzcy]

Description

When a PR is merged, the action should be trigged by push event. But on Gitea UI, it's showing under PR commit. The issue is introduced in v1.19.4.

Gitea Version

v1.19.4

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

This shows the actions is triggered by push and is associated with commit.

However, on the main branch, the action doesn't show up.

Under the already merged PR's last commit, the action is showing.

Git Version

No response

Operating System

No response

How are you running Gitea?

Run in Kubernetes.

Database

PostgreSQL

[wolfogre]

Could you please show us your workflow file?

[harryzcy]

@wolfogre

Edit: well, after posting this, I realized the workflow is expected not to run on push to main branch (with tags-ignore and no included branches). That's an error on me.

But should merging PR trigger an event at all? Is that expected to trigger another pull_request event?

name: Tests

on:
  push:
    tags-ignore:
      - "v*"
  pull_request:
    branches: [main]

jobs:
  python-test:
    name: Python Tests
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: https://github.com/actions/checkout@v3

      # - name: Set up Python
      #   uses: https://github.com/actions/setup-python@v4
      #   with:
      #     python-version: "3.11"
      - name: Set up Python
        run: |
          VERSION=3.11.4
          cd /tmp/
          wget -q https://www.python.org/ftp/python/$VERSION/Python-$VERSION.tgz
          tar -xzvf Python-$VERSION.tgz > /dev/null
          cd Python-$VERSION/

          apt-get update > /dev/null
          apt-get install -y build-essential zlib1g-dev libncurses5-dev libgdbm-dev libnss3-dev libssl-dev libreadline-dev libffi-dev > /dev/null

          ./configure --enable-optimizations > /dev/null
          make -j `nproc` > /dev/null
          make altinstall > /dev/null
          python3.11 -V

          ln -s /usr/local/bin/python3.11 /usr/local/bin/python
          ln -s /usr/local/bin/pip3.11 /usr/local/bin/pip

          python -VV

      - name: Install dependencies
        run: |
          python -m pip install --upgrade pip
          pip install pytest pytest-cov ruff
          pip install -r requirements.txt

      - name: Test with pytest
        run: |
          pytest --cov --cov-report=term-missing

[Zettat123]

The first line of job log should show the trigger event. Could you please check the log and show us the trigger event?

[harryzcy]

@Zettat123 For your question, it's triggered by pull_request.

Now with the following workflow, two action gets triggered by merging the pull request.

name: Tests

on:
  push:
    tags-ignore:
      - "v*"
    branches:
      - main
  pull_request:
    branches: [main]

The one on a detached commit is triggered by pull_request.

The one on main is triggered by push.

[Zettat123]

#24048 didn't match the activity type of pull_request event correctly. #25746 will fix the bug.