notification settings option text "and your own notifications" unclear

[thigg]

Description

It is unclear to me what the "and your own notifications" option means in the notification settings.

I think the text is improved. (And maybe also the available options could be more fine customizable as well..)

Gitea Version

1.19

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

self hosted debian

Database

SQLite

[puni9869]

Please propose the changes that suites the best, I will take it forward from then,
Ps: The current text seems fine to me.

[thigg]

If it is correct that this enables email notifications for notifications that i caused. E.g. "you pushed this commit" "you made this comment" then I'd propose

and notifications for my own actions

I think the "and" chain is understandable. What i didnt understand what notifications are not mine.

[puni9869]

@lunny need your attention for a moment.

[lunny]

Maybe we should change these as a radiobox list and every item should have a description.

[puni9869]

We can put a lil i button or tool tip in radio button title.
I will propose a UI shortly for it. I have some ideas.

[chris-08154711]

What's unclear is what is the other side of the "And" operator?
By selecting that option I am getting "X" "And my own notifications" ...what is X?

[patrick-gohier-cliffs]

Bump - I'm here because one of my engineers wants to tweak email notifications and I have no idea what this option does (doesn't seem to be documented anywhere either).

[puni9869]

Apologies for the delay, I will take a look into it this weekend.

[chris-08154711]

Proposal: Discard the "Enable" keyword and label the options just by what they actually contain. Swap the first two to get an order by number of mails.

Old	New
And your own notifications	All notifications
Enable Email Notifications	All except own notifications
Only email on mention	Only on mention
Disable email notifications	Disable email notifications

I am not sure about "except own" - sounds like I wont get any that are directed to myself. Maybe something like "except self inflicted" or "except triggered myself".
Maybe a native speaker can come up with a proper wording ;)

[patrick-gohier-cliffs]

Proposal: Discard the "Enable" keyword and label the options just by what they actually contain. Swap the first two to get an order by number of mails.

Old New
And your own notifications All notifications
Enable Email Notifications All except own notifications
Only email on mention Only on mention
Disable email notifications Disable email notifications
I am not sure about "except own" - sounds like I wont get any that are directed to myself. Maybe something like "except self inflicted" or "except triggered myself". Maybe a native speaker can come up with a proper wording ;)

Can you clarify what "all except own notifications" does?

[thigg]

Good proposal. I like "except triggered by me"

[buckybytes]

For anyone who wants to take a stab at this. The actual text values are in options/locale/locale_en-US.ini

email_notifications.enable = Enable Email Notifications
email_notifications.onmention = Only Email on Mention
email_notifications.disable = Disable Email Notifications
email_notifications.submit = Set Email Preference
email_notifications.andyourown = And Your Own Notifications

I made an attempt, but the maintainers wanted the variable names changed as well. I attempted to find all the occurrences of the two that needed changing, but was unsuccessful. The "AndYourOwn" and "Enabled" language is used in other places as well, so it may need a few levels of search and replace before it is all removed.

[chris-08154711]

Btw I tested "And Your Own" a little these days (due to "Only on Mention" not working as expected, see below) and it seems it writes way to many mails. Feels more or less the same as "Enabled". I am getting a lots of mails on PRs and stuff that I am really not involved with. Please check your definition/the expected behavior of "And Your Own" and fix if needed ;)

Also "Only Email on Mention" does NOT include the notification when a reviewer has approved MY PullRequest. But that would be really helpful at this point.

Regards

[JVimes]

I did not understand the and-chain. The following would have worked for me.

Email on:

• All actions
• All but my actions
• @ mention only
• Nothing

(I'm not sure the use care for getting emailed on things I did.)

[chris-08154711]

We found out that the spam everyone received with the "enabled" setting was caused by the gitea setting AUTO_WATCH_NEW_REPOS, which is by default set to true. So every developer was watching every repository and therefore receiving a lot of unwanted notifications.
Maybe consider shipping gitea with this setting false by default ;)