Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade script should inform users that gitea service has to be running in order to upgrade it #23949

Closed
ijustlovemath opened this issue Apr 6, 2023 · 3 comments
Labels
good first issue Likely to be an easy fix type/bug

Comments

@ijustlovemath
Copy link

Description

I'm running a non-docker install on a Debian VPS, and was upgrading from 1.18.3 to 1.19.0, using the upgrade script found here: https://github.com/go-gitea/gitea/blob/main/contrib/upgrade.sh

Following the backup steps, I stopped the gitea service with #systemctl stop gitea, did the manual backups, and then ran the upgrade script # ./upgrade.sh.

This upgrade script expects the service to be running (since it runs the flush queues command before making a backup), so when it encounters an Internal Server Error, it should suggest you have the service running before executing the upgrade script.

Gitea Version

1.18.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian

How are you running Gitea?

Using a prebuilt binary fetched with the Upgrade script. Original install came from Linode Marketplace (which had something like 1.16.x)

Database

PostgreSQL

@yardenshoham yardenshoham added the good first issue Likely to be an easy fix label Apr 7, 2023
@roy9495
Copy link
Contributor

roy9495 commented Apr 21, 2023

Can I contribute? And do I add the script at the beginning of the script?

silverwind added a commit that referenced this issue Apr 25, 2023
…to be running in order to upgrade it (#24260)

Hello sir,
This pull request solves issue #23949
I have updated the upgrade script such that it will check if the Gitea
service is running, if it's not running then it will exit the process
and if it's running then the process will move further ahead.
Thank You.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
Co-authored-by: silverwind <me@silverwind.io>
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jul 24, 2023

Closed by #23949 #24260

But, actually, the script should not require Gitea is running, it should just ignore the "flush queue" failure if there is no running instance.

@ijustlovemath
Copy link
Author

You linked this issue and not the PR, btw!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Likely to be an easy fix type/bug
Projects
None yet
Development

No branches or pull requests

4 participants