Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitea broken in latest commit #23838

Closed
JakobDev opened this issue Mar 31, 2023 · 6 comments · Fixed by #23844
Closed

Gitea broken in latest commit #23838

JakobDev opened this issue Mar 31, 2023 · 6 comments · Fixed by #23844
Labels
type/bug
Milestone
1.20.0

Comments

@JakobDev
Copy link
Contributor

Description

In the latest commit, Gitea is complete broken (see Screenshot). It looks like the assets file serves no content.

Gitea Version

288c2e8

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

https://gist.github.com/JakobDev/f8438f293ae4ea7fba877896f572914e

Screenshots

grafik

Git Version

2.39.2

Operating System

Manjaro

How are you running Gitea?

Build with TAGS="bindata sqlite sqlite_unlock_notify" make build

Database

None
@sclu1034
Copy link

I've been experiencing the same thing. Running without the bindata tag serves as a workaround for now.

@lunny
Copy link
Member

lunny commented Mar 31, 2023

I cannot reproduce this on my local machine.

@wolfogre
Copy link
Member

wolfogre commented Mar 31, 2023 •
edited
Loading

I can reproduce, need move the binary out of the code repo dir and start it. only for the installation page

@lunny
Copy link
Member

lunny commented Mar 31, 2023

I can now reproduce it. It's only for the installation page. After installation is finished, it will become normal.

@lunny
Copy link
Member

lunny commented Mar 31, 2023

Caused by #23495, 1.19 branch is also affected. @wxiaoguang

@lunny lunny added this to the 1.19.1 milestone Mar 31, 2023
@wxiaoguang wxiaoguang mentioned this issue Mar 31, 2023
Merged
@wxiaoguang
Copy link
Contributor

See: Fix incorrect CORS failure detection logic #23844

1.19 is not affected.

@silverwind silverwind modified the milestones: 1.19.1, 1.20.0 Mar 31, 2023
techknowlogick pushed a commit that referenced this issue Mar 31, 2023
@wxiaoguang
Fix incorrect CORS failure detection logic (#23844)
78046e5 
Regression of #23495

Fixes #23838
Fixes #23850
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging a pull request may close this issue.

Fix incorrect CORS failure detection logic wxiaoguang/gitea
6 participants
@lunny @silverwind @wxiaoguang @sclu1034 @wolfogre @JakobDev