Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The menu in review comment page has layout problem #23517

Closed
yp05327 opened this issue Mar 16, 2023 · 8 comments · Fixed by #23523
Closed

The menu in review comment page has layout problem #23517

yp05327 opened this issue Mar 16, 2023 · 8 comments · Fixed by #23523
Labels

Comments

@yp05327
Copy link
Contributor

yp05327 commented Mar 16, 2023

Description

image

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

build

Database

None

@silverwind
Copy link
Member

Should probably converted to use tippy.js.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 16, 2023

I do not think that menu could be easily replaced by tippy.

I guess changing the z-index: 7 of .diff-file-header.sticky-2nd-row to z-index: 1 is enough.

@wxiaoguang
Copy link
Contributor

I guess changing the z-index: 7 of .diff-file-header.sticky-2nd-row to z-index: 1 is enough.

Sorry .... it seems not working, more complex than I thought ....

@wxiaoguang
Copy link
Contributor

It's another regression of #22959

Without the overflow-x: scroll, it just works ......

image

@silverwind
Copy link
Member

silverwind commented Mar 16, 2023

I do not think that menu could be easily replaced by tippy.

I thought the same dropdown in issue comments was already using tippy, but apparently not. Maybe I'll check out later to convert both these menus. tippy is the ideal solution for such overflow issues :)

Without the overflow-x: scroll, it just works ......

Never use scroll overflow as it forces a scrollbar, better use auto which shows it only when necessary.

@wxiaoguang
Copy link
Contributor

Without the overflow-x: scroll, it just works ......

Never use scroll overflow as it forces a scrollbar, better use auto which shows it only when necessary.

#22959 wants to render a wide CSV table.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 16, 2023

tippy is the ideal solution for such overflow issues :)

Not that easy, these "dropdown menus" are quite complex, and there are still a11y concerns.


I guess we can have a quick fix at the moment: Fix review comment context menu clipped bug #23523

@silverwind
Copy link
Member

#22959 wants to render a wide CSV table.

Don't see why a max-width and overflow-x: auto shouldn't work. Scrollbars only on-demand.

techknowlogick pushed a commit that referenced this issue Mar 16, 2023
This is another regression of #22959 (the first regression has been
fixed by the Image Diff fix)

Close #23517

This is a quick fix. Luckily, there is no "dropdown menu" for image/csv
view, so we could only add the "overflow-x: scroll" to the image/csv
view.

After fix:


![image](https://user-images.githubusercontent.com/2114189/225643575-9e964b4f-5543-4a69-86c2-2ffc8e40d9a6.png)


![image](https://user-images.githubusercontent.com/2114189/225643670-f0e575d0-f4af-41f4-b023-2d9ddb6462e9.png)

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
wxiaoguang added a commit to wxiaoguang/gitea that referenced this issue Mar 17, 2023
This is another regression of go-gitea#22959 (the first regression has been
fixed by the Image Diff fix)

Close go-gitea#23517

This is a quick fix. Luckily, there is no "dropdown menu" for image/csv
view, so we could only add the "overflow-x: scroll" to the image/csv
view.

After fix:


![image](https://user-images.githubusercontent.com/2114189/225643575-9e964b4f-5543-4a69-86c2-2ffc8e40d9a6.png)


![image](https://user-images.githubusercontent.com/2114189/225643670-f0e575d0-f4af-41f4-b023-2d9ddb6462e9.png)

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
techknowlogick added a commit that referenced this issue Mar 17, 2023
Backport #23523, Close #23517

There is no "dropdown menu" for image/csv view, so we could only add the
"overflow-x: scroll" to the image/csv view.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants