-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The menu in review comment page has layout problem #23517
Comments
Should probably converted to use tippy.js. |
I do not think that menu could be easily replaced by tippy. I guess changing the |
Sorry .... it seems not working, more complex than I thought .... |
It's another regression of #22959 Without the |
I thought the same dropdown in issue comments was already using tippy, but apparently not. Maybe I'll check out later to convert both these menus. tippy is the ideal solution for such overflow issues :)
Never use |
#22959 wants to render a wide CSV table. |
Not that easy, these "dropdown menus" are quite complex, and there are still a11y concerns. I guess we can have a quick fix at the moment: Fix review comment context menu clipped bug #23523 |
Don't see why a |
This is another regression of #22959 (the first regression has been fixed by the Image Diff fix) Close #23517 This is a quick fix. Luckily, there is no "dropdown menu" for image/csv view, so we could only add the "overflow-x: scroll" to the image/csv view. After fix: ![image](https://user-images.githubusercontent.com/2114189/225643575-9e964b4f-5543-4a69-86c2-2ffc8e40d9a6.png) ![image](https://user-images.githubusercontent.com/2114189/225643670-f0e575d0-f4af-41f4-b023-2d9ddb6462e9.png) Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
This is another regression of go-gitea#22959 (the first regression has been fixed by the Image Diff fix) Close go-gitea#23517 This is a quick fix. Luckily, there is no "dropdown menu" for image/csv view, so we could only add the "overflow-x: scroll" to the image/csv view. After fix: ![image](https://user-images.githubusercontent.com/2114189/225643575-9e964b4f-5543-4a69-86c2-2ffc8e40d9a6.png) ![image](https://user-images.githubusercontent.com/2114189/225643670-f0e575d0-f4af-41f4-b023-2d9ddb6462e9.png) Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Description
Gitea Version
latest
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
build
Database
None
The text was updated successfully, but these errors were encountered: