push mirror sync_on_commit api call parameter not working
#22990
Comments
jolheiser
pushed a commit
that referenced
this issue
Feb 23, 2023
Fix: #22990 --- Before, the return value of the api is always false,regrardless of whether the entry of `sync_on_commit` is true or false. I have confirmed that the value of `sync_on_commit` dropped into the database is correct. So, I think it is enough to make some small changes.
yardenshoham
pushed a commit
to yardenshoham/gitea
that referenced
this issue
Feb 23, 2023
…#23088) Fix: go-gitea#22990 --- Before, the return value of the api is always false,regrardless of whether the entry of `sync_on_commit` is true or false. I have confirmed that the value of `sync_on_commit` dropped into the database is correct. So, I think it is enough to make some small changes.
lunny
added a commit
that referenced
this issue
Feb 24, 2023
…23100) Backport #23088 Fix: #22990 --- Before, the return value of the api is always false,regrardless of whether the entry of `sync_on_commit` is true or false. I have confirmed that the value of `sync_on_commit` dropped into the database is correct. So, I think it is enough to make some small changes. Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
I am trying to add a push mirror using the
push_mirrorsapi endpoint but thesync_on_commitparameter is not taken into account. The reply returnssync_on_commit: falseevery time.However manually enabling the option the UI works ! I tested by manually adding a push mirror on the UI then making a commit+push which produces a sync. The problem is only on the Gitea API's side with the json field parameter.
I am sure there is no issue with my query, it's clean json data, the push mirror api endpoint adds the mirrors that I specify but does not want to enable the
sync_on_commitparameter. The rest works including theintervalone.I tried
devrun mode anddebuglogging there is no error. The query runs fine.I don't have time to dig into the code but it looks like the endpoint simply does not handle the json field
sync_on_commitGitea Version
1.18.3
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
there is no error in the log just a successful API post query to push mirrors
Screenshots
No response
Git Version
2.36.4, Wire Protocol Version 2 Enabled
Operating System
Linux Debian
How are you running Gitea?
Self hosted at
https://git.blob42.xyzDatabase
SQLite
The text was updated successfully, but these errors were encountered: