Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is an error viewing the LFS file #22734

Closed
hiifong opened this issue Feb 3, 2023 · 2 comments · Fixed by #22945
Closed

There is an error viewing the LFS file #22734

hiifong opened this issue Feb 3, 2023 · 2 comments · Fixed by #22945
Assignees
@Zettat123
Labels
type/bug

Comments

@hiifong
Copy link
Contributor

hiifong commented Feb 3, 2023 •
edited
Loading

Description

No response

Gitea Version

1.18.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

2023-02-03_17-25-41.mp4

Git Version

No response

Operating System

No response

How are you running Gitea?

./gitea web

Database

MySQL
@Zettat123
Copy link
Contributor

I'm trying to fix this bug.

@Zettat123 Zettat123 mentioned this issue Feb 17, 2023
Merged
@hiifong
Copy link
Contributor Author

hiifong commented Feb 17, 2023

I'm trying to fix this bug.

thank you very much

lunny pushed a commit that referenced this issue Feb 17, 2023
@Zettat123 @wolfogre
Fix 404 error viewing the LFS file (#22945)
5a12e95 
Fix #22734.

According to
[`view_file.tmpl`](https://github.com/go-gitea/gitea/blob/main/templates/repo/view_file.tmpl#L82),
`lfs_file.tmpl` should use `AssetUrlPrefix` instead of `AppSubUrl`.

Co-authored-by: Jason Song <i@wolfogre.com>
@yardenshoham yardenshoham mentioned this issue Feb 17, 2023
Merged
yardenshoham pushed a commit to yardenshoham/gitea that referenced this issue Feb 17, 2023
@Zettat123 @wolfogre @yardenshoham
Fix 404 error viewing the LFS file (go-gitea#22945)
9bcbca7 
Fix go-gitea#22734.

According to
[`view_file.tmpl`](https://github.com/go-gitea/gitea/blob/main/templates/repo/view_file.tmpl#L82),
`lfs_file.tmpl` should use `AssetUrlPrefix` instead of `AppSubUrl`.

Co-authored-by: Jason Song <i@wolfogre.com>
lunny pushed a commit that referenced this issue Feb 17, 2023
@yardenshoham @Zettat123 @wolfogre
Fix 404 error viewing the LFS file (#22945) (#22948)
98b7714 
Backport #22945

Fix #22734.

According to
[`view_file.tmpl`](https://github.com/go-gitea/gitea/blob/main/templates/repo/view_file.tmpl#L82),
`lfs_file.tmpl` should use `AssetUrlPrefix` instead of `AppSubUrl`.

Co-authored-by: Zettat123 <zettat123@gmail.com>
Co-authored-by: Jason Song <i@wolfogre.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Zettat123 Zettat123

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 404 error viewing the LFS file Zettat123/gitea
2 participants
@Zettat123 @hiifong