Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook Improvement #1702

Closed
DblK opened this issue May 10, 2017 · 4 comments
Closed

Webhook Improvement #1702

DblK opened this issue May 10, 2017 · 4 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@DblK
Copy link
Member

DblK commented May 10, 2017

When I used the actual webhook, I saw that there is still some "Gogs" implementation, so first we should modify it.

I would also suggest to modify the webhook implementation by dividing it into two sort of webhook.
One for incoming and another for outgoing (as it is right now).

If we implement incoming webhook, it can be a nice implementation for CI result of commit or PR (see #996).

For the implementation on the UI, I would suggest either add another button for "Incoming Webhook" and rename "Add Webhook" to "Outgoing Webhook" or use icons in the list like the following ones:
image

What do you think about those improvements?

@lunny
Copy link
Member

lunny commented May 10, 2017

what's the different between incoming webhooks and outgoing webhoks ?

@DblK
Copy link
Member Author

DblK commented May 10, 2017

For Outgoing webhook, it's only when Gitea will POST to another url like Rocket.Chat, Mattermost,...

The Incoming webhooks is when another application POST to Gitea that will handle the post to do something.
I can see a use of incoming webhook to drone for example POST a result and Gitea will handle it to update a table with the build status.

I am clear enough?

@DblK
Copy link
Member Author

DblK commented May 12, 2017

After digging to the code and on github api, I found this (https://developer.github.com/v3/repos/statuses/).
My proposal for incoming webhook does not have to exist because of the API that I forgot :p.

So the only thing I think we should do is to remove the "GOGS" information in all webhook.
See, there for example.

I can make a PR very quickly ;)

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label May 12, 2017
@DblK
Copy link
Member Author

DblK commented May 26, 2017

I made a PR for adding Gitea Webhook #1755.
However the status are already inside the code, so nothing to do with this issue anymore.

@DblK DblK closed this as completed May 26, 2017
@lunny lunny modified the milestones: 1.3.0, 1.2.0 May 26, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants