-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Css specifies emoji fonts for body text #13784
Comments
I am using FF but am not seeing what you see in screenshots, could you confirm the operating system and version of FF you are using? |
Linux, Firefox beta 84.0. It's fine on a Windows virtual machine. I guess the |
I'm seeing this as well, similar setup as @Oreolek |
Is it only numbers? I guess one could use CSS unicode-range to just exclude glyphs 1-9 thought I wonder if there are better solutions. Also, this kind of smells like a Firefox bug, it should prefer the sans-serif fonts if they are installed. |
Can someone test if putting |
@silverwind that works but it's not the proper way to define a font stack and might break something else down the line, possibly |
What do you suggest? We can't really wrap all emoji in their own elements after all. |
are they being used elsewhere? this is honestly the first time i noticed them. all other icons i've seen on the web interface seem to come from an icon font (like fontawesome or some such) and are contained in elements |
Emoji can of course appear anywhere where there is user content and we might even use them at some point in our own templates. I think it's unavoidable to have those fonts in the font stack. |
Update to latest Bootstrap font stack [1]. Should fix go-gitea#13784. [1] https://github.com/twbs/bootstrap/blob/bf3c4d0b6891c21377e6b1fb7962f5fbf198325f/scss/_variables.scss#L396
Please try #13834. |
Update to latest Bootstrap font stack [1]. Should fix #13784. [1] https://github.com/twbs/bootstrap/blob/bf3c4d0b6891c21377e6b1fb7962f5fbf198325f/scss/_variables.scss#L396 Co-authored-by: 6543 <6543@obermui.de>
Description
_base.less
specifies the body and headings font family as:This looks fine on Chrome but I guess you didn't test on Firefox because Firefox prints all numbers as emoji. Everywhere. It's hideous.
Screenshots
Also see #12966 because that bug is about the same CSS line.
The text was updated successfully, but these errors were encountered: