Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css specifies emoji fonts for body text #13784

Closed
1 of 2 tasks
Oreolek opened this issue Dec 2, 2020 · 10 comments · Fixed by #13834
Closed
1 of 2 tasks

Css specifies emoji fonts for body text #13784

Oreolek opened this issue Dec 2, 2020 · 10 comments · Fixed by #13834

Comments

@Oreolek
Copy link

Oreolek commented Dec 2, 2020

Description

_base.less specifies the body and headings font family as:

-apple-system,BlinkMacSystemFont,system-ui,Segoe UI,Roboto,Helvetica,Arial, Apple Color Emoji,Segoe UI Emoji,Noto Color Emoji,Twemoji Mozilla, sans-serif

This looks fine on Chrome but I guess you didn't test on Firefox because Firefox prints all numbers as emoji. Everywhere. It's hideous.

Screenshots

1

Also see #12966 because that bug is about the same CSS line.

@techknowlogick
Copy link
Member

I am using FF but am not seeing what you see in screenshots, could you confirm the operating system and version of FF you are using?

@Oreolek
Copy link
Author

Oreolek commented Dec 2, 2020

Linux, Firefox beta 84.0. It's fine on a Windows virtual machine.

I guess the Noto Color Emoji is the first font installed on my system (I have Arial and Roboto but they're not used for some reason, and they're custom-installed anyway.)

@itsdeadguy
Copy link

I'm seeing this as well, similar setup as @Oreolek

@silverwind
Copy link
Member

silverwind commented Dec 3, 2020

Is it only numbers? I guess one could use CSS unicode-range to just exclude glyphs 1-9 thought I wonder if there are better solutions.

Also, this kind of smells like a Firefox bug, it should prefer the sans-serif fonts if they are installed.

@silverwind
Copy link
Member

Can someone test if putting sans-serif before the emoji fonts solves this?

@itsdeadguy
Copy link

itsdeadguy commented Dec 3, 2020

@silverwind that works but it's not the proper way to define a font stack and might break something else down the line, possibly
edit: forgot to say that yes, it's only the numbers

@silverwind
Copy link
Member

What do you suggest? We can't really wrap all emoji in their own elements after all.

@itsdeadguy
Copy link

itsdeadguy commented Dec 3, 2020

are they being used elsewhere? this is honestly the first time i noticed them. all other icons i've seen on the web interface seem to come from an icon font (like fontawesome or some such) and are contained in elements

@silverwind
Copy link
Member

Emoji can of course appear anywhere where there is user content and we might even use them at some point in our own templates. I think it's unavoidable to have those fonts in the font stack.

@silverwind
Copy link
Member

Please try #13834.

zeripath pushed a commit that referenced this issue Dec 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants